Closed Bug 1287024 Opened 4 years ago Closed 4 years ago

Remove unused mHashStores variable in Classifier.cpp

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: dimi, Assigned: dimi)

Details

Attachments

(1 file)

When working on bug 1037560, i found |mHashStores| is only used by code that remove it, but actually no one is using this variable.

We Should remove this variable.
Summary: Clean unused mHashStores variable in Classifier.cpp → Remove unused mHashStores variable in Classifier.cpp
Attached patch Patch v1Splinter Review
Attachment #8771257 - Flags: feedback?(hchang)
Attachment #8771257 - Flags: feedback?(hchang) → feedback+
Attachment #8771257 - Flags: review?(francois)
Comment on attachment 8771257 [details] [diff] [review]
Patch v1

Review of attachment 8771257 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup :)
Attachment #8771257 - Flags: review?(francois) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6951eb08d083
Remove unused mHashStores variable in Classifier.cpp. r=francois
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6951eb08d083
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.