Closed
Bug 1287024
Opened 8 years ago
Closed 8 years ago
Remove unused mHashStores variable in Classifier.cpp
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: dlee, Assigned: dlee)
Details
Attachments
(1 file)
|
1.93 KB,
patch
|
francois
:
review+
hchang
:
feedback+
|
Details | Diff | Splinter Review |
When working on bug 1037560, i found |mHashStores| is only used by code that remove it, but actually no one is using this variable. We Should remove this variable.
|
Assignee | |
Updated•8 years ago
|
Summary: Clean unused mHashStores variable in Classifier.cpp → Remove unused mHashStores variable in Classifier.cpp
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8771257 -
Flags: feedback?(hchang)
|
||
Updated•8 years ago
|
Attachment #8771257 -
Flags: feedback?(hchang) → feedback+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8771257 -
Flags: review?(francois)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8771257 [details] [diff] [review] Patch v1 Review of attachment 8771257 [details] [diff] [review]: ----------------------------------------------------------------- Nice cleanup :)
Attachment #8771257 -
Flags: review?(francois) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fc23f0ecbf7
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6951eb08d083 Remove unused mHashStores variable in Classifier.cpp. r=francois
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6951eb08d083
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•