1287083 - 'measure' command not working if the Measuring Tool was previously enabled via the Toolbox button

Status: RESOLVED INCOMPLETE

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P3)

Description

[Sebastian Zartner [:sebo]]

The 'measure' command doesn't work if the tool got previously enabled via the 'Measure a portion of the page' Toolbar button.

Steps taken from bug 1089240 comment 85:

1. Launch FF with a clean profile.
2. Enable Toogle tools (Ctrl+Shift+I).
3. Enable Developer Toolbar (Shift+F2).
4. Open Toolbox Options and enable 'Measure a portion of the page' option.
5. Disable and re-enable the option from step 4.
6. Enable the Measure tool by clicking on the Measure a portion of the page icon.
7. Disable the measure tool by using the 'measure' command in the Developer Toolbar.

Sebastian

Comment 1

[Joe Walker [:jwalker]]

Thanks for the report and the STR, however without an "Expected", it's hard for me to work out what's wrong, because it looks to be working to me, perhaps the problem is that the help should read "Toggle the measuring tool ..."?
CC: zer0

Comment 2

[Sebastian Zartner [:sebo]]

I can clearly reproduce the issue with the given steps above.
The observed result is that the tool is still enabled, i.e. you can measure an area within the page, after you executed the 'measure' command. This means the 'measure' command cannot disable the tool anymore.

The opposite case can also happen. I.e. you cannot enable the tool anymore via the 'measure' command when you previously enabled it via the Toolbox button.

My steps:
1. Lauch Firefox with a clean profile
2. Enable the DevTools via Ctrl+Shift+I
3. Enable the GCLI via Shift+F2
4. Switch to the Toolbox Options
5. Check the option 'Measure a portion of the page' to display the Toolbox button
6. Click the Toolbox button 'Measure a portion of the page'
   => Measuring Tool is enabled. (OK)
7. Execute the 'measure' command
   => The tool is still enabled but should be disabled at this point. (BUG)
8. Click the Toolbox button 'Measure a portion of the page' again
   => Measuring Tool is disabled. (OK)
9. Execute the 'measure' command again
   => The tool should be enabled again but it stays disabled. (BUG)

This issue is somewhat related to bug 1262773.

Sebastian

Comment 3

[Joe Walker [:jwalker]]

Re-adding ni? for Matteo.

Comment 4

[Sebastian Zartner [:sebo]]

(In reply to Joe Walker [:jwalker] (needinfo me or ping on irc) from comment #3)
> Re-adding ni? for Matteo.

Sorry for clearing the ni! I thought it was meant for providing the "Expected".

Sebastian

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Sebastian Zartner [:sebo] from comment #2)
> I can clearly reproduce the issue with the given steps above.

It seems working for me too, so I'm not able to reproduce the issue described – at least on the latest Nightly, 50.0a1 (2016-07-18). To be more clear:

> 1. Lauch Firefox with a clean profile
> 2. Enable the DevTools via Ctrl+Shift+I
> 3. Enable the GCLI via Shift+F2
> 4. Switch to the Toolbox Options
> 5. Check the option 'Measure a portion of the page' to display the Toolbox
> button
> 6. Click the Toolbox button 'Measure a portion of the page'
>    => Measuring Tool is enabled. (OK)
> 7. Execute the 'measure' command
>    => The tool is still enabled but should be disabled at this point. (BUG)

At this point, executing the measure command from the GCLI, toggles the toolbox button properly, so the button is not highlighted anymore and the measuring tool is removed from the page.

Could you give us more information? OS and Firefox version you've tested – and, in case it's not the latest Nightly, could you try the latest Nightly to see if it's still happening to you?

Thanks!

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to Matteo Ferretti [:zer0] [:matteo] from comment #5)
> (In reply to Sebastian Zartner [:sebo] from comment #2)
> > I can clearly reproduce the issue with the given steps above.
> 
> It seems working for me too, so I'm not able to reproduce the issue
> described – at least on the latest Nightly, 50.0a1 (2016-07-18). To be more
> clear:
> 
> > 1. Lauch Firefox with a clean profile
> > 2. Enable the DevTools via Ctrl+Shift+I
> > 3. Enable the GCLI via Shift+F2
> > 4. Switch to the Toolbox Options
> > 5. Check the option 'Measure a portion of the page' to display the Toolbox
> > button
> > 6. Click the Toolbox button 'Measure a portion of the page'
> >    => Measuring Tool is enabled. (OK)
> > 7. Execute the 'measure' command
> >    => The tool is still enabled but should be disabled at this point. (BUG)
> 
> At this point, executing the measure command from the GCLI, toggles the
> toolbox button properly, so the button is not highlighted anymore and the
> measuring tool is removed from the page.

For me the Toolbox button quickly unhighlights then highlights again. If there was a measured area, it is removed but the measuring tool is still available within the page.
So, it looks like the tool gets disabled and immediately enabled again.

Maybe you can reproduce it with these slightly different steps:
1. Lauch Firefox with a clean profile
2. Enable the DevTools via Ctrl+Shift+I
3. Enable the GCLI via Shift+F2
4. Switch to the Toolbox Options
5. Check the option 'Measure a portion of the page' to display the Toolbox button
6. Execute the 'measure' command
   => Measuring Tool is enabled. (OK)
7. Execute the 'measure' command
   => The tool is not enabled and the Toolbox button stays unhighlighted. (BUG)

When you repeat step 7 nothing it's always the same result, the tool cannot be enabled via the 'measure' command.

> Could you give us more information? OS and Firefox version you've tested

Sure, it is Nightly 50.0a1 (2016-07-19) on Windows 7, both 64-bit. Sorry for not providing that info earlier!

Sebastian

Comment 7

[Firefox Bug Husbandry Bot]

Per bug 1491875, this component has been closed, and the affected code is being removed from Firefox. Closing this bug as incomplete.