1287086 - IONFLAGS=logs causes Assertion failure: fallibleScope_ ([OOM] Cannot allocate a new chunk in an infallible scope.)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

This error message is made to catch any allocation issue which does not ensure that we have enough ballast space.

As this code is not used in production, maybe we can just disable this method of reporting OOM on the C1Spewer as well as the JSONSpewer.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Use LifoAlloc::AutoFallibleScope in LSprinter::put.

The LSprinter already check for fallible allocations, but as it reuses the
LifoAlloc of the compiler, it inherits the infallible aspect of it.

Thus we have to explicit that we use the LifoAlloc as a fallible allocator
in debug builds.

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 8771397 [details] [diff] [review]
Use LifoAlloc::AutoFallibleScope in LSprinter::put.

Review of attachment 8771397 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Printer.cpp
@@ +533,5 @@
>      Chunk* last = reinterpret_cast<Chunk*>(alloc_->alloc(allocLength));
>      if (!last) {
>          reportOutOfMemory();
>          return origLen - len;
>      }

Please put the this snippit in it's own scope. That way the fallible scope is only present for those few lines, instead of the full function.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/895a11230f50
Use LifoAlloc::AutoFallibleScope in LSprinter::put. r=h4writer

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/895a11230f50