1287094 - Wrong icon for Sidebar toggle button

Status: RESOLVED INVALID

(DevTools :: Inspector, defect)

Description

[Ada [:adalucinet]]

[Affected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit
- Mac OS X 10.9.5
- Ubuntu 16.04 64-bit

[Steps to reproduce]:
1. Launch Firefox.
2. Open Inspector: Ctrl + Shift + C (for Windows & Ubuntu) or Cmd + Opt + C (for Mac OS X).
3. Focus the Sidebar toggle button.

[Expected result]:
- Sidebar toggle button is properly displayed.

[Actual result]:
- Sidebar toggle button is not properly displayed.

[Regression range]:
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=b50931952fbb76037bff76715e1f17f7fd80e34c&tochange=31cab0ba8bbf1d88b08abeae45bcdf317645355a
-  Found commit message:Bug 1247331: Make import snapshot an icon

[Additional notes]:
- Screenshot: https://i.imgur.com/xCE70CS.png
- Couldn't figure it out if the change in bug 1247331 was supposed to affect Sidebar toggle button too; although, filed this issue to have it under our radar if that's not the case. Helen, looking forward for your input. Thanks in advance!

Comment 1

[Helen V. Holmes (:helenvholmes) (:✨)]

Hey Alexandra,

That was indeed a purposeful change from bug 1260523. Did you notice anything wrong with the icon other than the style change?