Closed Bug 1287144 Opened 8 years ago Closed 8 years ago

Synthetic bolding of fonts in <canvas> is broken by the switch to Skia canvas backend

Categories

(Core :: Graphics: Text, defect)

48 Branch
Unspecified
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1287552
Tracking Status
firefox48 --- wontfix
firefox49 --- fix-optional
firefox50 --- fix-optional

People

(Reporter: jfkthame, Assigned: lsalzman)

References

()

Details

(Keywords: regression, Whiteboard: [gfx-noted])

See testcase at http://jsfiddle.net/env8zvmd/ (assumes availability of the DejaVu Serif font).

The second line of canvas text, which should be emboldened, is not rendered correctly. The glyph spacing is increased, in line with the expected spacing of emboldened glyphs, but the actual glyphs themselves are not modified; just the regular glyphs are rendered.

In contrast, synthetic bold *does* work as expected for the HTML DOM text in the testcase.

Setting gfx.canvas.azure.backends to 'cairo' results in the expected synthetic bold rendering. So this is a regression from the switch to Skia.
Version: 44 Branch → Trunk
Blocks: 1164136
This is because the SkFontHost_cairo backend does not process emboldening yet. That slipped under the radar. I have some in-progress work on revising it to be more feature complete in preparation for Skia content that should resolve this.

Need-infoing myself here to remind me I need to mark this bug as dependent on the SkFontHost_cairo rewrite bug once I set it up.
Flags: needinfo?(lsalzman)
Whiteboard: [gfx-noted]
Flags: needinfo?(lsalzman)
Need-info: once more, with feeling...
Flags: needinfo?(lsalzman)
Assignee: nobody → lsalzman
Version: Trunk → 48 Branch
Depends on: 1287552
Once bug 1287552 lands, this should be fixed.
Flags: needinfo?(lsalzman)
Thanks, Lee. I can confirm this now works correctly in my testing. So I think we can resolve as a dupe of bug 1287552; this was a visible symptom of that underlying problem.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.