Closed Bug 1287146 Opened 3 years ago Closed 3 years ago

Remove unused argument from NodeInfoChanged()

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

It looks like nsXMLElement::NodeInfoChanged() used to use this argument, but now there's only a single non-empty implementation, in nsGenericHTMLFormElementWithState.
Comment on attachment 8772562 [details] [diff] [review]
Remove unused argument from NodeInfoChanged().

Review of attachment 8772562 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: dom/base/nsNodeUtils.cpp
@@ +503,5 @@
>        oldDoc->ClearBoxObjectFor(element);
>        wasRegistered = oldDoc->UnregisterActivityObserver(element);
>      }
>  
>      aNode->mNodeInfo.swap(newNodeInfo);

I think you could replace this .swap() with a mNodeInfo = newNodeInfo.forget() now if you wanted.
Attachment #8772562 - Flags: review?(bkelly) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea6df4951b56
Remove unused argument from NodeInfoChanged(). r=bkelly
https://hg.mozilla.org/mozilla-central/rev/ea6df4951b56
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.