1287166 - Use a little less NS_ADDREF in DOM code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Use NS_ADDREF less in dom/.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e87c342a58d

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8772561 [details] [diff] [review]
Use NS_ADDREF less in dom/.

Review of attachment 8772561 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: dom/base/nsGenericDOMDataNode.h
@@ +172,5 @@
>  
>    virtual nsresult Clone(mozilla::dom::NodeInfo *aNodeInfo, nsINode **aResult) const override
>    {
> +    nsCOMPtr<nsINode> result = CloneDataNode(aNodeInfo, true);
> +    if (!result) {

The previous code had the side effect of clearing *aResult when CloneDataNode() returned nullptr.  It would be slightly safer to put the forget() before the short-circuit here.  If you are sure it doesn't matter, though, then this is fine.

Comment 3

[Andrew McCreight [:mccr8]]

That's a good point. I'll do that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf7983226fbe
Use NS_ADDREF less in dom/. r=bkelly

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf7983226fbe