Closed
Bug 1287176
Opened 8 years ago
Closed 8 years ago
Status file not written for staging errors
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | unaffected |
firefox49 | --- | unaffected |
firefox-esr45 | --- | fixed |
firefox50 | + | fixed |
firefox51 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: regression)
Attachments
(2 files, 7 obsolete files)
10.21 KB,
patch
|
molly
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
96.01 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
This is fallout from bug 1168743
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8771502 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Updated•8 years ago
|
status-firefox47:
--- → unaffected
status-firefox48:
--- → unaffected
status-firefox49:
--- → unaffected
status-firefox50:
--- → affected
status-firefox-esr45:
--- → unaffected
Updated•8 years ago
|
Attachment #8771502 -
Flags: review?(spohl.mozilla.bugs) → review+
Assignee | ||
Comment 2•8 years ago
|
||
I need to also update tests and will submit a test patch after I have finished.
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8771502 -
Attachment is obsolete: true
Assignee | ||
Comment 4•8 years ago
|
||
I rat holed quite a bit on this but I *think* this should be it.
Assignee | ||
Comment 5•8 years ago
|
||
I tried to keep the client changes to a minimum except for comments.
Attachment #8780457 -
Attachment is obsolete: true
Attachment #8780458 -
Attachment is obsolete: true
Attachment #8780462 -
Flags: review?(mhowell)
Assignee | ||
Comment 6•8 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=57f3370ef45c
Attachment #8780463 -
Flags: review?(mhowell)
Assignee | ||
Comment 7•8 years ago
|
||
Forgot to revert var DEBUG_AUS_TEST = true; back to false
Attachment #8780463 -
Attachment is obsolete: true
Attachment #8780463 -
Flags: review?(mhowell)
Attachment #8780464 -
Flags: review?(mhowell)
Assignee | ||
Comment 8•8 years ago
|
||
There was a trailing space in a comment in the previous patch
Attachment #8780462 -
Attachment is obsolete: true
Attachment #8780462 -
Flags: review?(mhowell)
Attachment #8780473 -
Flags: review?(mhowell)
Comment 9•8 years ago
|
||
marAppInUseStageSuccessComplete_unix.js failed in that try push on both Mac and Linux, with: [checkPostUpdateAppLogFinished : 73] the update manager updateCount attribute should equal the expected value - 1 == 2 I'll review after that's fixed.
Flags: needinfo?(robert.strong.bugs)
Assignee | ||
Comment 10•8 years ago
|
||
Attachment #8780464 -
Attachment is obsolete: true
Attachment #8780473 -
Attachment is obsolete: true
Attachment #8780464 -
Flags: review?(mhowell)
Attachment #8780473 -
Flags: review?(mhowell)
Flags: needinfo?(robert.strong.bugs)
Assignee | ||
Comment 11•8 years ago
|
||
Try server push https://treeherder.mozilla.org/#/jobs?repo=try&revision=29439c367282
Assignee | ||
Updated•8 years ago
|
Attachment #8780600 -
Flags: review?(mhowell)
Assignee | ||
Updated•8 years ago
|
Attachment #8780601 -
Flags: review?(mhowell)
Updated•8 years ago
|
Attachment #8780600 -
Flags: review?(mhowell) → review+
Updated•8 years ago
|
Attachment #8780601 -
Flags: review?(mhowell) → review+
Comment 12•8 years ago
|
||
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/10819baa58fc client code - Status file not written for staging errors. r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/49a53da6979c test code - Status file not written for staging errors. r=mhowell
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/10819baa58fc https://hg.mozilla.org/mozilla-central/rev/49a53da6979c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment 14•8 years ago
|
||
Can/should we uplift this to 50 (seems it's also affected)?
Flags: needinfo?(robert.strong.bugs)
Assignee | ||
Comment 15•8 years ago
|
||
[Tracking Requested - why for this release]: This fixes a regression where update staging failures aren't handled properly.
tracking-firefox50:
--- → ?
Flags: needinfo?(robert.strong.bugs)
Assignee | ||
Comment 16•8 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #14) > Can/should we uplift this to 50 (seems it's also affected)? After it bakes on nightly for a couple of days.
Tracked since it's a recent regression in 50.
Assignee | ||
Comment 18•8 years ago
|
||
Comment on attachment 8780600 [details] [diff] [review] client code rev2 Approval Request Comment [Feature/regressing bug #]: Bug 1168743 [User impact if declined]: Failed stage updates won't be handled properly [Describe test coverage new/current, TreeHerder]: This has baked on nightly for a few days, the updated tests are thorough, and I've verified this locally. [Risks and why]: It is possible that I might have missed a case this should handle but I spent a decent amount of time verifying all of the cases this needs to handle are handled. Also, the current fallbacks should prevent breaking updates as it did for this case. [String/UUID change made/needed]: None
Attachment #8780600 -
Flags: approval-mozilla-aurora?
Comment on attachment 8780600 [details] [diff] [review] client code rev2 Improves our handling of failed staged updates, stabilized on Nightly for a week, Aurora50+
Attachment #8780600 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 20•8 years ago
|
||
Pushed to mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/89e811fde1ac900bdd55b071d3d397dc80afb31d https://hg.mozilla.org/releases/mozilla-aurora/rev/ddd7e7dd100e8f631696a0060f7ac5bcb2345d0b
Assignee | ||
Comment 21•8 years ago
|
||
Pushed to mozilla-esr45 with approval in bug 1246945 https://hg.mozilla.org/releases/mozilla-esr45/rev/0569d5dce9db https://hg.mozilla.org/releases/mozilla-esr45/rev/804d7029982c
Updated•7 years ago
|
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•