Closed Bug 1287176 Opened 5 years ago Closed 5 years ago
Status file not written for staging errors
This is fallout from bug 1168743
Attachment #8771502 - Flags: review?(spohl.mozilla.bugs) → review+
I need to also update tests and will submit a test patch after I have finished.
I rat holed quite a bit on this but I *think* this should be it.
I tried to keep the client changes to a minimum except for comments.
Forgot to revert var DEBUG_AUS_TEST = true; back to false
There was a trailing space in a comment in the previous patch
marAppInUseStageSuccessComplete_unix.js failed in that try push on both Mac and Linux, with: [checkPostUpdateAppLogFinished : 73] the update manager updateCount attribute should equal the expected value - 1 == 2 I'll review after that's fixed.
Attachment #8780600 - Flags: review?(mhowell)
Attachment #8780601 - Flags: review?(mhowell)
Attachment #8780600 - Flags: review?(mhowell) → review+
Attachment #8780601 - Flags: review?(mhowell) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/10819baa58fc client code - Status file not written for staging errors. r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/49a53da6979c test code - Status file not written for staging errors. r=mhowell
Can/should we uplift this to 50 (seems it's also affected)?
[Tracking Requested - why for this release]: This fixes a regression where update staging failures aren't handled properly.
(In reply to Andrew Overholt [:overholt] from comment #14) > Can/should we uplift this to 50 (seems it's also affected)? After it bakes on nightly for a couple of days.
Comment on attachment 8780600 [details] [diff] [review] client code rev2 Approval Request Comment [Feature/regressing bug #]: Bug 1168743 [User impact if declined]: Failed stage updates won't be handled properly [Describe test coverage new/current, TreeHerder]: This has baked on nightly for a few days, the updated tests are thorough, and I've verified this locally. [Risks and why]: It is possible that I might have missed a case this should handle but I spent a decent amount of time verifying all of the cases this needs to handle are handled. Also, the current fallbacks should prevent breaking updates as it did for this case. [String/UUID change made/needed]: None
Attachment #8780600 - Flags: approval-mozilla-aurora?
No longer blocks: 1291985
Comment on attachment 8780600 [details] [diff] [review] client code rev2 Improves our handling of failed staged updates, stabilized on Nightly for a week, Aurora50+
Attachment #8780600 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to mozilla-esr45 with approval in bug 1246945 https://hg.mozilla.org/releases/mozilla-esr45/rev/0569d5dce9db https://hg.mozilla.org/releases/mozilla-esr45/rev/804d7029982c
You need to log in before you can comment on or make changes to this bug.