Closed Bug 1287185 Opened 3 years ago Closed 3 years ago

Disable paint-skipping for elements with background-attachment:local

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox48 --- wontfix
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

This is similar to bug 1284586, but for background-attachment:local. Again, APZ doesn't properly handle background-attachment:local and with paint-skipping enabled the visual effect can get very laggy. With paint-skipping turned off on these elements it's much better. Bug 1267656 tracks fixing this properly, by implementing support for background-attachment:local that works with async scrolling.
Comment on attachment 8771516 [details]
Bug 1287185 - Disable paint skipping for scrollframes with background-attachment:local.

https://reviewboard.mozilla.org/r/64644/#review61694
Attachment #8771516 - Flags: review?(mstange) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a50ebf3ebab
Disable paint skipping for scrollframes with background-attachment:local. r=mstange
https://hg.mozilla.org/mozilla-central/rev/1a50ebf3ebab
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8771516 [details]
Bug 1287185 - Disable paint skipping for scrollframes with background-attachment:local.

Approval Request Comment
[Feature/regressing bug #]: APZ
[User impact if declined]: Pages with background-attachment:local have the background visibly lag when the scrollframe is scrolled. The URL in the bug URL field has an example. This is similar to the fix we did in bug 1284586, disabling APZ in specific cases to make the behaviour less bad
[Describe test coverage new/current, TreeHerder]: tested locally
[Risks and why]: low risk, it's a pretty small patch
[String/UUID change made/needed]: none
Attachment #8771516 - Flags: approval-mozilla-beta?
Attachment #8771516 - Flags: approval-mozilla-aurora?
(Note also that bug 1267656 tracks fixing this properly)
Hi Kartikaya,
May I know when/how the bug is introduced?
Flags: needinfo?(bugmail)
Comment on attachment 8771516 [details]
Bug 1287185 - Disable paint skipping for scrollframes with background-attachment:local.

Too late in the 48 cycle.
Attachment #8771516 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
(In reply to Gerry Chang [:gchang] from comment #7)
> Hi Kartikaya,
> May I know when/how the bug is introduced?

The bug was introduced by turning on APZ, which doesn't properly support background-attachment:local. It was made worse by enabling paint-skipping in bug 1253860 and bug 1257641. This patch turns off paint-skipping for these scrollframes and improves the situation considerably.
Flags: needinfo?(bugmail)
Comment on attachment 8771516 [details]
Bug 1287185 - Disable paint skipping for scrollframes with background-attachment:local.

As mentioned in comment #9, this patch turns off paint-skipping can improve the situation considerably. Take it in 49 aurora.
Attachment #8771516 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.