1287229 - port.disconnect() should not throw an error if the port is already disconnected

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Rob Wu [:robwu]]

https://developer.chrome.com/extensions/runtime#type-Port

> Calling disconnect() on an already-disconnected port has no effect.

I.e. disconnect() ought to be no-op if the port is already disconnected. In contrast, Firefox throws an error: http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/toolkit/components/extensions/ExtensionUtils.jsm#1051

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1287229 - port.disconnect should not throw

Review commit: https://reviewboard.mozilla.org/r/64734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64734/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8771628 [details]
Bug 1287229 - port.disconnect should not throw

https://reviewboard.mozilla.org/r/64734/#review62068

::: toolkit/components/extensions/ExtensionUtils.jsm:1049
(Diff revision 1)
>      }
>    },
>  
>    disconnect() {
>      if (this.disconnected) {
> -      throw new this.context.contentWindow.Error("Attempt to disconnect() a disconnected port");
> +      return;

Please add a comment with a link to the Chrome docs.

Comment 3

[Rob Wu [:robwu]]

Comment on attachment 8771628 [details]
Bug 1287229 - port.disconnect should not throw

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64734/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8e2132fa883
port.disconnect should not throw r=billm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e8e2132fa883