|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Recent versions of node seem to have removed the "-1 = randomly assigned port" behavior for socket.listen, and it's a real pain to have to deal with that when testing local changes on the spdy and h2 tests (since my laptop has a much more modern node than we're running in infra). Instead, it's now "0 = randomly assigned port". This appears to work fine in infra, too (https://treeherder.mozilla.org/#/jobs?repo=try&revision=e61514209dde) so let's make the switch.
Created attachment 8771599 [details] Bug 1287236 - Use 0 instead of -1 to randomly assign port. Review commit: https://reviewboard.mozilla.org/r/64700/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64700/
Attachment #8771599 - Flags: review?(mcmanus)
Comment on attachment 8771599 [details] Bug 1287236 - Use 0 instead of -1 to randomly assign port. https://reviewboard.mozilla.org/r/64700/#review61772
Attachment #8771599 - Flags: review?(mcmanus) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/059794b8004e Use 0 instead of -1 to randomly assign port. r=mcmanus
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.