Fix port selector in moz-spdy and moz-http2

RESOLVED FIXED in Firefox 50

Status

()

Core
Networking: HTTP
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nwgh, Assigned: nwgh)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [necko-active])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Recent versions of node seem to have removed the "-1 = randomly assigned port" behavior for socket.listen, and it's a real pain to have to deal with that when testing local changes on the spdy and h2 tests (since my laptop has a much more modern node than we're running in infra). Instead, it's now "0 = randomly assigned port". This appears to work fine in infra, too (https://treeherder.mozilla.org/#/jobs?repo=try&revision=e61514209dde) so let's make the switch.
Created attachment 8771599 [details]
Bug 1287236 - Use 0 instead of -1 to randomly assign port.

Review commit: https://reviewboard.mozilla.org/r/64700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64700/
Attachment #8771599 - Flags: review?(mcmanus)
Comment on attachment 8771599 [details]
Bug 1287236 - Use 0 instead of -1 to randomly assign port.

https://reviewboard.mozilla.org/r/64700/#review61772
Attachment #8771599 - Flags: review?(mcmanus) → review+

Comment 3

2 years ago
Pushed by hurley@todesschaf.org:
https://hg.mozilla.org/integration/autoland/rev/059794b8004e
Use 0 instead of -1 to randomly assign port. r=mcmanus

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/059794b8004e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.