Closed
Bug 1287236
Opened 8 years ago
Closed 8 years ago
Fix port selector in moz-spdy and moz-http2
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: u408661, Assigned: u408661)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
Recent versions of node seem to have removed the "-1 = randomly assigned port" behavior for socket.listen, and it's a real pain to have to deal with that when testing local changes on the spdy and h2 tests (since my laptop has a much more modern node than we're running in infra). Instead, it's now "0 = randomly assigned port". This appears to work fine in infra, too (https://treeherder.mozilla.org/#/jobs?repo=try&revision=e61514209dde) so let's make the switch.
Review commit: https://reviewboard.mozilla.org/r/64700/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64700/
Attachment #8771599 -
Flags: review?(mcmanus)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8771599 [details] Bug 1287236 - Use 0 instead of -1 to randomly assign port. https://reviewboard.mozilla.org/r/64700/#review61772
Attachment #8771599 -
Flags: review?(mcmanus) → review+
Pushed by hurley@todesschaf.org: https://hg.mozilla.org/integration/autoland/rev/059794b8004e Use 0 instead of -1 to randomly assign port. r=mcmanus
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/059794b8004e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•