1287247 - some things being bold and more yellow lies/misleads about what changes are being made

Status: RESOLVED DUPLICATE of bug 1224733

(MozReview Graveyard :: Review Board: User Interface, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When I'm reading diffs in the mozreview diff viewer, it makes lines that are "changed" have a pale yellow background.

But for some lines, it notices that only a particular thing changed, and makes that thing (in both the old and new parts) bold and with a stronger yellow background.

This is a useful feature, because it tells me that I only need to look at the bits that are bold with the stronger yellow background.

But the UI only does this on some lines.  There are other yellow lines where there are *more* changes, but nothing is bold and yellow.

However, the UI encourages me to skip over those changes.

I'm nearly sure that at this point I've granted review to code changes that I didn't even read because of this, even though I've been aware of the problem before (and I thought I even filed a bug about it).

The UI just keeps encouraging me to ignore substantive changes, and I keep doing it, and then (sometimes?  usually?) catch myself doing so.

I consider this unacceptable, and I'm probably going to stop using the MozReview UI after the current patch I'm reviewing in it:
https://reviewboard.mozilla.org/r/41887/diff/1
which is a pretty horrible example of this.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot

There's more than one difference here!

Comment 2

[Mark Côté [:mcote]]

Yeah that's terrible.  I believe this is bug 1224733 (and bug 1257396 was also filed on your behalf by glob).  I'm going to get someone to fix this as soon as we can.