Closed
Bug 1287289
Opened 7 years ago
Closed 7 years ago
Add checkboxes to open the data manager and the addon manager in standalone windows instead of a browser tab
Categories
(SeaMonkey :: Preferences, enhancement)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.48
People
(Reporter: rsx11m.pub, Assigned: rsx11m.pub)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
7.33 KB,
patch
|
iannbugzilla
:
review+
philip.chee
:
ui-review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1255354 +++ (Quoting rsx11m from bug 1255354 comment #3) > We should probably have a bug to expose those prefs in the UI once this is done, e.g., in the > "Tabbed Browsing" prefpane (though neither Add-ons nor Data Manager are specific to "Browser") > or "Advanced" as a more general alternative. An easy fix is to invert the prefs and add them to "Tabbed Browsing" like: Open tabs instead of windows for [x] Middle-click, Ctrl+click or Ctrl+Enter on links in a Web page [x] Ctrl+Enter in the Location bar [ ] When opening the Data Manager [ ] When opening the Add-ons Manager Since they open in a browser tab, it's sort of related to the Browser category but may nevertheless be obscure.
I'll go with the Tabbed Browsing prefpane as proposed. I don't see any better fit than that, and there is sufficient space left to add those two checkboxes. Intuitively, if you are looking for a place to toggle whether to open something in a tab or rather in its own window, "Tabbed Browsing" would probably be my first best guess where to find it.
I have listed Data Manager before Add-Ons Manager as this is the order they appear in the Tools menu. I've also added a paragraph and link to the prefpane Help in the "Using the Add-Ons Manager" description and planned to do the same for the Data Manager, but apparently we still don't have some help text for it (that's bug 599097).
Attachment #8772371 -
Flags: ui-review?(philip.chee)
Attachment #8772371 -
Flags: review?(iann_bugzilla)
![]() |
||
Comment 3•7 years ago
|
||
Comment on attachment 8772371 [details] [diff] [review] Proposed patch "Open tabs instead of windows for" ... "When opening the ..." is rather awkward. How about a new groupbox with: Open in a new tab instead of a separate (stand-alone?) window for the [ ] Data Manager [ ] Add-on Manager
Attachment #8772371 -
Flags: ui-review?(philip.chee) → ui-review-
(In reply to Philip Chee from comment #3) > Open in a new tab instead of a separate (stand-alone?) window for the > [ ] Data Manager > [ ] Add-on Manager Ok, I've made it a separate group and opted for "stand-alone window" in the group caption. I didn't use "for the" given that the previous group /with/ that "for" was about actions whereas this group is about objects (managers), thus there is no logical continuation of the sentence but simply an itemized list follows. I stole the 'd' accesskey from autoHide as an 'e' in "Data Manager" comes really way back.
Attachment #8772371 -
Attachment is obsolete: true
Attachment #8772371 -
Flags: review?(iann_bugzilla)
Attachment #8780295 -
Flags: ui-review?(philip.chee)
Attachment #8780295 -
Flags: review?(iann_bugzilla)
![]() |
||
Comment 5•7 years ago
|
||
Comment on attachment 8780295 [details] [diff] [review] Proposed patch (v2) r+ a=me if necessary
Attachment #8780295 -
Flags: ui-review?(philip.chee) → ui-review+
Thanks for the a+, but this still needs r=IanN before I can push it. ;-)
Comment on attachment 8780295 [details] [diff] [review] Proposed patch (v2) a/r=me
Attachment #8780295 -
Flags: review?(iann_bugzilla) → review+
Landed as http://hg.mozilla.org/comm-central/rev/1b975add1587
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.48
You need to log in
before you can comment on or make changes to this bug.
Description
•