Use ScopedAutoSECItem in PSM more

RESOLVED FIXED in Firefox 50

Status

()

Core
Security: PSM
P1
minor
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
ScopedAutoSECItem is useful for:
1. Removing manual memory management.
2. Getting rid of this pattern:
   > UniqueSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
   While this pattern works, ScopedAutoSECItem is slightly superior in that it
   doesn't unnecessarily cause a SECItem to be allocated from the heap.
(Assignee)

Comment 1

2 years ago
Created attachment 8774252 [details]
Bug 1287290 - Use ScopedAutoSECItem in PSM more.

ScopedAutoSECItem is useful for:
1. Removing manual memory management.
2. Getting rid of this pattern:
   > UniqueSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
   While this pattern works, ScopedAutoSECItem is slightly superior in that it
   doesn't unnecessarily cause a SECItem to be allocated from the heap.

Review commit: https://reviewboard.mozilla.org/r/66784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66784/
Attachment #8774252 - Flags: review?(dkeeler)
Comment on attachment 8774252 [details]
Bug 1287290 - Use ScopedAutoSECItem in PSM more.

https://reviewboard.mozilla.org/r/66784/#review63756

Awesome - r=me.
Attachment #8774252 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

2 years ago
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=685e4959c12a
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8a4ca6608d9
Use ScopedAutoSECItem in PSM more. r=dkeeler
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f8a4ca6608d9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Updated

2 years ago
See Also: → bug 1308890
You need to log in before you can comment on or make changes to this bug.