Closed Bug 1287290 Opened 4 years ago Closed 4 years ago

Use ScopedAutoSECItem in PSM more

Categories

(Core :: Security: PSM, defect, P1, minor)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

ScopedAutoSECItem is useful for:
1. Removing manual memory management.
2. Getting rid of this pattern:
   > UniqueSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
   While this pattern works, ScopedAutoSECItem is slightly superior in that it
   doesn't unnecessarily cause a SECItem to be allocated from the heap.
ScopedAutoSECItem is useful for:
1. Removing manual memory management.
2. Getting rid of this pattern:
   > UniqueSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
   While this pattern works, ScopedAutoSECItem is slightly superior in that it
   doesn't unnecessarily cause a SECItem to be allocated from the heap.

Review commit: https://reviewboard.mozilla.org/r/66784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66784/
Attachment #8774252 - Flags: review?(dkeeler)
Comment on attachment 8774252 [details]
Bug 1287290 - Use ScopedAutoSECItem in PSM more.

https://reviewboard.mozilla.org/r/66784/#review63756

Awesome - r=me.
Attachment #8774252 - Flags: review?(dkeeler) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8a4ca6608d9
Use ScopedAutoSECItem in PSM more. r=dkeeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f8a4ca6608d9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
See Also: → 1308890
You need to log in before you can comment on or make changes to this bug.