Fix filter icon in Canvas

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Developer Tools: Canvas Debugger
VERIFIED FIXED
9 months ago
6 months ago

People

(Reporter: magicp, Assigned: Towkir, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 52
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox50 affected, firefox51 affected, firefox52 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 months ago
Created attachment 8771699 [details]
Fix filter icon in Canvas.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160716030215

Steps to reproduce:

1. Start Nightly
2. Go to "http://helloracer.com/webgl/"
3. Open DevTools > Canvas
4. Confirm filter icon in inputbox


Actual results:

Using search icon (search.svg)


Expected results:

Filter icon (filter.svg)
(Reporter)

Updated

9 months ago
Has STR: --- → yes
status-firefox50: --- → affected
Component: Untriaged → Developer Tools: Canvas Debugger
OS: Unspecified → All
Hardware: Unspecified → All
(Reporter)

Updated

8 months ago
status-firefox51: --- → affected

Comment 1

6 months ago
At https://dxr.mozilla.org/mozilla-central/source/devtools/client/canvasdebugger/canvasdebugger.xul#113

replace devtools-searchinput with devtools-filterinput
Mentor: ntim.bugs@gmail.com
Keywords: good-first-bug
(Reporter)

Updated

6 months ago
status-firefox52: --- → affected
(Assignee)

Comment 2

6 months ago
Created attachment 8803299 [details] [diff] [review]
filter_icon_vs_search_icon.patch

Hope this helps :)
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Attachment #8803299 - Flags: review?(ntim.bugs)

Comment 3

6 months ago
Comment on attachment 8803299 [details] [diff] [review]
filter_icon_vs_search_icon.patch

Review of attachment 8803299 [details] [diff] [review]:
-----------------------------------------------------------------

Works great, thanks for the patch!
Attachment #8803299 - Flags: review?(ntim.bugs) → review+

Updated

6 months ago
Keywords: checkin-needed

Comment 4

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d188cf31d797
Fix filter icon in Canvas by replacing the search icon. r=ntim
Keywords: checkin-needed

Comment 5

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d188cf31d797
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Comment 6

6 months ago
I have reproduced this bug with nightly 50.0a1 (2016-07-16) on windows 10, 32 bit.

The bug’s fix is now verified on Latest Nightly 52.0a1.

Build Id: 20161028030204.

User agent: Mozilla/5.0 (Windows NT 10.0; rv:52.0) Gecko/20100101 Firefox/52.0.

[bugday-20161026]

Updated

6 months ago
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.