1287326 - Misleading error messages in Linux builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

Since the landing of bug 1286649, I can no longer build 32-bit Linux under 64-bit OS.  I get the following error:

DEBUG: configure: error:  Could not find the following X libraries:  -lX11 -lXext -lX11-xcb -lxcb-shm -lxcb

Comment 1

[Bill Gianopoulos [:WG9s]]

I do this by defining the environment variable "PKG_CONFIG_PATH".  It would seem that the modified code does not respect this setting.

Comment 2

[Bill Gianopoulos [:WG9s]]

Nevermind, installing the 32-bit version of libxcb-devel fixed the issue.

Comment 3

[Bill Gianopoulos [:WG9s]]

OF course this does still leave the questions, why does this say none of these libraries was defined when the only issue was with lX11-xcb and lXcb-shm and -lxcb.  Misreporting that -lX11 and -lXext were also not found delayed figuring this up substantially.

Comment 4

[Bill Gianopoulos [:WG9s]]

This error message:

DEBUG: configure: error:  Could not find the following X libraries:  -lX11 -lXext -lX11-xcb -lxcb-shm -lxcb

implies that none of the listed libraries could be found, when in fact, it is really trying to say that one or more of the listed libraries could not be found.

Comment 5

[shadabk96]

(In reply to Bill Gianopoulos [:WG9s] from comment #2)
> Nevermind, installing the 32-bit version of libxcb-devel fixed the issue.

How did you install the 32-bit version of libxcb-devel ? I am using Ubuntu and am unable to resolve the error.

Comment 6

[Andrew Overholt [:overholt]]

Andrew, can we improve the error message here?

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to Andrew Overholt [:overholt] from comment #6)
> Andrew, can we improve the error message here?

I am not sure it is specifically a gfx issue or if this question needs to go to build-config.

Comment 8

[Andrew Comminos [:acomminos]]

(In reply to Andrew Overholt [:overholt] from comment #6)
> Andrew, can we improve the error message here?

We could, sure; currently we just throw all of our linker flags for missing X libraries into $MISSING_X and then spew it later during configure. We could potentially terminate early and suggest to the user packages that may provide said libraries.

Comment 9

[Andrew Comminos [:acomminos]]

So the core issue here of misreporting linker flags is caused by `-lX11-xcb -lxcb-shm -lxcb` being specified in the `other-libraries` AC_CHECK_LIB parameter for all X dependencies, causing the call to fail if xcb is not present, and thus reporting every X library into MISSING_X.

I'll fix up the missing symbol dependencies to make more sense.

Comment 10

[Andrew Comminos [:acomminos]]

Attachment: Bug 1287326 - Construct XLIBS incrementally to avoid incorrect dependency failures.

Review commit: https://reviewboard.mozilla.org/r/72666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72666/

Comment 11

[Mike Hommey [:glandium]]

Comment on attachment 8782543 [details]
Bug 1287326 - Construct XLIBS incrementally to avoid incorrect dependency failures.

https://reviewboard.mozilla.org/r/72666/#review70490

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0110fe4b2090
Construct XLIBS incrementally to avoid incorrect dependency failures. r=glandium

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0110fe4b2090

Comment 14

[Sylvestre Ledru [:Sylvestre]]

I think this can ride the trains.