Closed Bug 1287350 Opened 3 years ago Closed 3 years ago

Call WatchManager::Shutdown() in MediaDecoder::Shutdown() to prevent notifications from watchables

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

https://hg.mozilla.org/mozilla-central/file/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/dom/media/MediaDecoder.cpp#l646

It is awkward to unwatch mIsAudioDataAudible only in Shutdown(). The code will be more readable if we call WatchManager::Shutdown() to unwatch all mirrors.
Assignee: nobody → jwwang
Priority: -- → P3
Comment on attachment 8771875 [details]
Bug 1287350. Part 1 - extract some code to {Connect,Disconnect}Mirrors. .

https://reviewboard.mozilla.org/r/64832/#review62172
Attachment #8771875 - Flags: review?(jyavenard) → review+
Comment on attachment 8771876 [details]
Bug 1287350. Part 2 -  Call WatchManager::Shutdown() to prevent notifications from watchables.

https://reviewboard.mozilla.org/r/64834/#review62174
Attachment #8771876 - Flags: review?(jyavenard) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42a9d72c1c08
Part 1 - extract some code to {Connect,Disconnect}Mirrors. r=jya.
https://hg.mozilla.org/integration/autoland/rev/5d68d9dba658
Part 2 -  Call WatchManager::Shutdown() to prevent notifications from watchables. r=jya
https://hg.mozilla.org/mozilla-central/rev/42a9d72c1c08
https://hg.mozilla.org/mozilla-central/rev/5d68d9dba658
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.