Closed
Bug 1287350
Opened 3 years ago
Closed 3 years ago
Call WatchManager::Shutdown() in MediaDecoder::Shutdown() to prevent notifications from watchables
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
P3
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(2 files)
https://hg.mozilla.org/mozilla-central/file/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/dom/media/MediaDecoder.cpp#l646 It is awkward to unwatch mIsAudioDataAudible only in Shutdown(). The code will be more readable if we call WatchManager::Shutdown() to unwatch all mirrors.
|
Assignee | |
Comment 1•3 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=68d913b7826f
|
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → jwwang
Priority: -- → P3
|
|
Assignee | |
Comment 2•3 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/64832/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64832/
Attachment #8771875 -
Flags: review?(jyavenard)
Attachment #8771876 -
Flags: review?(jyavenard)
|
|
Assignee | |
Comment 3•3 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/64834/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64834/
|
||
Comment 4•3 years ago
|
||
Comment on attachment 8771875 [details] Bug 1287350. Part 1 - extract some code to {Connect,Disconnect}Mirrors. . https://reviewboard.mozilla.org/r/64832/#review62172
Attachment #8771875 -
Flags: review?(jyavenard) → review+
|
|
||
Comment 5•3 years ago
|
||
Comment on attachment 8771876 [details] Bug 1287350. Part 2 - Call WatchManager::Shutdown() to prevent notifications from watchables. https://reviewboard.mozilla.org/r/64834/#review62174
Attachment #8771876 -
Flags: review?(jyavenard) → review+
|
|
Assignee | |
Comment 6•3 years ago
|
||
Thanks for the review!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42a9d72c1c08 Part 1 - extract some code to {Connect,Disconnect}Mirrors. r=jya. https://hg.mozilla.org/integration/autoland/rev/5d68d9dba658 Part 2 - Call WatchManager::Shutdown() to prevent notifications from watchables. r=jya
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/42a9d72c1c08 https://hg.mozilla.org/mozilla-central/rev/5d68d9dba658
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•