Closed Bug 1287351 Opened 3 years ago Closed 3 years ago

OdinMonkey: MIPS: Implement many simple operations in the MacroAssembler

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

Other
Unspecified
defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: hev, Assigned: hev)

References

Details

Attachments

(2 files, 1 obsolete file)

See Bug 1278283
Attachment #8771839 - Flags: review?(lhansen)
Attachment #8771839 - Attachment is obsolete: true
Attachment #8771839 - Flags: review?(lhansen)
Attachment #8771874 - Flags: review?(lhansen)
Priority: -- → P3
Comment on attachment 8771840 [details] [diff] [review]
Part 2 - Implement many simple operations in the MacroAssembler.

Review of attachment 8771840 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips-shared/MacroAssembler-mips-shared-inl.h
@@ +276,5 @@
> +MacroAssembler::absFloat32(FloatRegister src, FloatRegister dest)
> +{
> +    if (src != dest)
> +        as_movs(dest, src);
> +    as_abss(dest, dest);

Not that it's any of my business, but the MIPS manual suggests that as_abss(dest, src) would be fine here, you don't need the MOVS.  (I'm not a MIPS expert.)

@@ +284,5 @@
> +MacroAssembler::absDouble(FloatRegister src, FloatRegister dest)
> +{
> +    if (src != dest)
> +        as_movd(dest, src);
> +    as_absd(dest, dest);

Ditto.
Attachment #8771840 - Flags: review?(lhansen) → review+
Attachment #8771874 - Flags: review?(lhansen) → review+
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ac147f1004e
IonMonkey: MIPS: Expose max and min in the MacroAssembler + move code. r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/d19427e7135c
OdinMonkey: MIPS: Implement many simple operations in the MacroAssembler. r=lth
https://hg.mozilla.org/mozilla-central/rev/6ac147f1004e
https://hg.mozilla.org/mozilla-central/rev/d19427e7135c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.