OdinMonkey: MIPS: Implement many simple operations in the MacroAssembler

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine: JIT
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: hev, Assigned: hev)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Other
Unspecified
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

a year ago
See Bug 1278283
(Assignee)

Comment 1

a year ago
Created attachment 8771839 [details] [diff] [review]
Part 1 - Expose max and min in the MacroAssembler + move code.
Attachment #8771839 - Flags: review?(lhansen)
(Assignee)

Comment 2

a year ago
Created attachment 8771840 [details] [diff] [review]
Part 2 - Implement many simple operations in the MacroAssembler.
Attachment #8771840 - Flags: review?(lhansen)
(Assignee)

Comment 3

a year ago
Created attachment 8771874 [details] [diff] [review]
Part 1 - Expose max and min in the MacroAssembler + move code.
Attachment #8771839 - Attachment is obsolete: true
Attachment #8771839 - Flags: review?(lhansen)
Attachment #8771874 - Flags: review?(lhansen)

Updated

a year ago
Priority: -- → P3
Comment on attachment 8771840 [details] [diff] [review]
Part 2 - Implement many simple operations in the MacroAssembler.

Review of attachment 8771840 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips-shared/MacroAssembler-mips-shared-inl.h
@@ +276,5 @@
> +MacroAssembler::absFloat32(FloatRegister src, FloatRegister dest)
> +{
> +    if (src != dest)
> +        as_movs(dest, src);
> +    as_abss(dest, dest);

Not that it's any of my business, but the MIPS manual suggests that as_abss(dest, src) would be fine here, you don't need the MOVS.  (I'm not a MIPS expert.)

@@ +284,5 @@
> +MacroAssembler::absDouble(FloatRegister src, FloatRegister dest)
> +{
> +    if (src != dest)
> +        as_movd(dest, src);
> +    as_absd(dest, dest);

Ditto.
Attachment #8771840 - Flags: review?(lhansen) → review+

Updated

a year ago
Attachment #8771874 - Flags: review?(lhansen) → review+

Comment 5

a year ago
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ac147f1004e
IonMonkey: MIPS: Expose max and min in the MacroAssembler + move code. r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/d19427e7135c
OdinMonkey: MIPS: Implement many simple operations in the MacroAssembler. r=lth

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6ac147f1004e
https://hg.mozilla.org/mozilla-central/rev/d19427e7135c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.