1287378 - Fix static analysis bustage in bug 1213517 landing.

Status: RESOLVED DUPLICATE of bug 1213517

(Core :: WebRTC: Audio/Video, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Two fixes for two static analysis reported problems on inbound.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1287378 - Fix static analysis for bug 1213517 landing: make constructor explicit.

Review commit: https://reviewboard.mozilla.org/r/64842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64842/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1287378 - Fix static analysis for bug 1213517 landing: Avoid non-memmovable nsTArray<NormalizedConstraintSet>.

Review commit: https://reviewboard.mozilla.org/r/64844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64844/

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I trust this should take care of it, but I dunno how to run static analysis locally, but the try in mozReview should tell us for sure.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Going to bed here. If anyone wants to review and land before tomorrow, feel free to steal review and autoland (unsure what the time limit is on avoiding backout here).

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try looks green.

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Moved patches to bug 1213517 since we got backed out.