1287387 - Expiring histograms: FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, FENNEC_RESTRICTED_PROFILE_RESTRICTIONS, ZOOMED_VIEW_ENABLED

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

The following histograms will be expiring on 2016-08-01, and should be removed from the codebase, or have their expiry versions updated:

* FENNEC_CUSTOM_HOMEPAGE expires in version 50.0a1 (watched by [e-mail]) - Whether the user has set a custom homepage.
* FENNEC_LOAD_SAVED_PAGE expires in version 50.0a1 (watched by [e-mail]) - How often users load saved items when online/offline (0=RL online, 1=RL offline, 2=BM online, 3=BM offline)
* FENNEC_RESTRICTED_PROFILE_RESTRICTIONS expires in version 50.0a1 (watched by [e-mail]) - Whether various restrictions are set, keyed by restiction name
* ZOOMED_VIEW_ENABLED expires in version 50.0a1 (watched by [e-mail]) - Whether or not a user has the zoomed view (a.k.a. "Magnify small areas") enabled.

Comment 1

[Barbara Bermes [:barbara] - NI please!]

I'd like to keep all these in, except the restricted profile as I don't think it's working properly or we need it anytime soon.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0.

Review commit: https://reviewboard.mozilla.org/r/73582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73582/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram.

Review commit: https://reviewboard.mozilla.org/r/73584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73584/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8783960 [details]
Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73582/diff/1-2/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8783961 [details]
Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73584/diff/1-2/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

@liuche: Bonus question, if a histogram probe expires in 50. Does it need to be removed in 50 or should it be gone in 51?

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8783960 [details]
Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0.

https://reviewboard.mozilla.org/r/73582/#review71558

The homepage and saved page probes seem reasonable to me.

Is work for zoomed view continuing? I thought the work stalled due to APZ integration problems.

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8783961 [details]
Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram.

https://reviewboard.mozilla.org/r/73584/#review71560

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9a227543979
Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0. r=liuche
https://hg.mozilla.org/integration/autoland/rev/ccd9edf8d384
Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram. r=liuche

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8783960 [details]
Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0.

Approval Request Comment
[Feature/regressing bug #]: Removing expired histograms (Expired in 50.0)
[User impact if declined]: -
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ba30caa81c0
[Risks and why]: Very low, only removing histograms.
[String/UUID change made/needed]: -

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8783961 [details]
Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram.

(see comment 10)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9a227543979
https://hg.mozilla.org/mozilla-central/rev/ccd9edf8d384

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8783960 [details]
Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0.

Extending histogram expiry, Aurora50+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6e4a66c6dfd3
https://hg.mozilla.org/releases/mozilla-aurora/rev/1536a4c14d4e