1287425 - [Static Analysis][Uninitialized scalar field] In function FuncImport

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that members of |pod| are not initialised in the default constructor of FuncImport.
In order to integrate our static analysis tool based on clang - AST we need to fix these issues.

Comment 1

[Andi [:andi]]

Attachment: Bug 1287425 - initialise all members from FuncImport in default ctor.

Review commit: https://reviewboard.mozilla.org/r/64926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64926/

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8771956 [details]
Bug 1287425 - initialise all members from FuncImport in default ctor.

Stealing.  Just so I understand, this is just to make it clear to the analysis, right?  I believe these are actually initialized before use.

Comment 3

[Andi [:andi]]

(In reply to Luke Wagner [:luke] from comment #2)
> Comment on attachment 8771956 [details]
> Bug 1287425 - initialise all members from FuncImport in default ctor.
> 
> Stealing.  Just so I understand, this is just to make it clear to the
> analysis, right?  I believe these are actually initialized before use.

Exactly, we would like to initialise all our resources in constructor as much as possible.

Comment 4

[Andi [:andi]]

for no reason the review still is not r+ in mozreview, that's why i've added you as a reviewer maybe this time works.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8056a7c17e64
initialise all members from FuncImport in default ctor. r=luke

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8056a7c17e64