[Static Analysis][Uninitialized scalar field] In function FuncImport

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla50
coverity
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: CID 1363753)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The Static Analysis tool Coverity detected that members of |pod| are not initialised in the default constructor of FuncImport.
In order to integrate our static analysis tool based on clang - AST we need to fix these issues.
(Assignee)

Comment 1

2 years ago
Created attachment 8771956 [details]
Bug 1287425 - initialise all members from FuncImport in default ctor.

Review commit: https://reviewboard.mozilla.org/r/64926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64926/
Attachment #8771956 - Flags: review?(jorendorff)

Comment 2

2 years ago
Comment on attachment 8771956 [details]
Bug 1287425 - initialise all members from FuncImport in default ctor.

Stealing.  Just so I understand, this is just to make it clear to the analysis, right?  I believe these are actually initialized before use.
Attachment #8771956 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Luke Wagner [:luke] from comment #2)
> Comment on attachment 8771956 [details]
> Bug 1287425 - initialise all members from FuncImport in default ctor.
> 
> Stealing.  Just so I understand, this is just to make it clear to the
> analysis, right?  I believe these are actually initialized before use.

Exactly, we would like to initialise all our resources in constructor as much as possible.
(Assignee)

Updated

2 years ago
Attachment #8771956 - Flags: review+ → review?(luke)
(Assignee)

Comment 4

2 years ago
for no reason the review still is not r+ in mozreview, that's why i've added you as a reviewer maybe this time works.

Updated

2 years ago
Attachment #8771956 - Flags: review?(luke) → review+

Comment 5

2 years ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8056a7c17e64
initialise all members from FuncImport in default ctor. r=luke

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8056a7c17e64
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.