Closed Bug 1287428 Opened 5 years ago Closed 5 years ago

Re-up or make immortal the FX_SANITIZE timing probes expiring in FF50

Categories

(Firefox :: General, defect)

49 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: chutten, Assigned: mak)

Details

Attachments

(1 file)

Thirteen Sanitize probes [1] will expire in FF50 which is real soon now.

Conversation with :mak on IRC suggests that we probably want to keep these as insurance against regressions in these timings (which could result in bad shutdown experiences)

The choice is whether we want to try and argue that these deserve to be "expires_in_version: never" or if these should only be re-upped for another X versions (X=5? 10?) to see if they actually _do_ catch regressions.

[1]:
* FX_SANITIZE_CACHE expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize the cache (ms)
* FX_SANITIZE_COOKIES expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize cookies (ms)
* FX_SANITIZE_COOKIES_2 expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize firefox cookies (ms). A subset of FX_SANITIZE_COOKIES.
* FX_SANITIZE_DOWNLOADS expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize recent downloads (ms)
* FX_SANITIZE_FORMDATA expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize stored form data (ms)
* FX_SANITIZE_HISTORY expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize history (ms)
* FX_SANITIZE_LOADED_FLASH expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize Flash when it's already loaded (ms). A subset of FX_SANITIZE_PLUGINS.
* FX_SANITIZE_OFFLINEAPPS expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize stored offline app data (ms)
* FX_SANITIZE_OPENWINDOWS expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize the open windows list (ms)
* FX_SANITIZE_PLUGINS expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize plugin cookies (ms). A subset of FX_SANITIZE_COOKIES.
* FX_SANITIZE_SESSIONS expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize saved sessions (ms)
* FX_SANITIZE_SITESETTINGS expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize site-specific settings (ms)
* FX_SANITIZE_UNLOADED_FLASH expires in version 50.0a1 (watched by firefox-dev@mozilla.org) - Sanitize: Time it takes to sanitize Flash when it's not yet loaded (ms). A subset of FX_SANITIZE_PLUGINS.
Flags: needinfo?(mak77)
Removing FX_SANITIZE_COOKIES cause it's a catch-all that is not really useful, FX_SANITIZE_COOKIES_2 does the right measure.
Removing FX_SANITIZE_PLUGINS cause plugins are pretty much deprecated. I bumped the FLASH probes to 55 though, we'll re-evaluate those.
Also OFFLINEAPPS is a deprecated feature afaict, quite uninteresting measurement (small) too.

Regardless we also have the total and in case we can add fine grained measurements when needed in future.
Flags: needinfo?(mak77)
Comment on attachment 8774784 [details]
Bug 1287428 - Fix expiration of the FX_SANITIZE_ probes expiring in v50.

https://reviewboard.mozilla.org/r/67212/#review64514
Attachment #8774784 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/fx-team/rev/75f7f076c3a8
Fix expiration of the FX_SANITIZE_ probes expiring in v50.r=adw
https://hg.mozilla.org/mozilla-central/rev/75f7f076c3a8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee: nobody → mak77
You need to log in before you can comment on or make changes to this bug.