Closed Bug 1287476 Opened 5 years ago Closed 5 years ago

With 1.0.4 changes, sometimes two pocket pages are opened

Categories

(Firefox :: Pocket, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 50
Tracking Status
firefox48 --- verified
firefox49 --- verified
firefox50 --- verified

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

Gijs:

I know you had qualms about the setTimeout in the first place. This is the proper fix, per Pocket.

They had originally had deletes, but those were flagged in strict mode:

https://github.com/mozilla-partners/pocket/pull/3
Attachment #8771999 - Flags: review?(gijskruitbosch+bugs) → review+
Blocks: 1276054
https://hg.mozilla.org/mozilla-central/rev/7ccf33128023
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8771999 [details] [diff] [review]
Remove setTimeout, just clear handlers

Approval Request Comment
[Feature/regressing bug #]: Double pages on clicking pocket button
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low
[String/UUID change made/needed]: None

This new code is already in aurora/beta. Would be nice to get this fix in there as well.
Attachment #8771999 - Flags: approval-mozilla-beta?
Attachment #8771999 - Flags: approval-mozilla-aurora?
Paul, can you verify that this issue is now resolved?
Flags: needinfo?(paul.silaghi)
Assignee: nobody → mozilla
Comment on attachment 8771999 [details] [diff] [review]
Remove setTimeout, just clear handlers

Review of attachment 8771999 [details] [diff] [review]:
-----------------------------------------------------------------

We'll have 48 beta 10 to fix the potential regressions. And, in the future, please fill the section of the template about testing (btw, "[Feature/regressing bug #]" is incorrect). Let's take it in 48 beta 10 and aurora.
Attachment #8771999 - Flags: approval-mozilla-beta?
Attachment #8771999 - Flags: approval-mozilla-beta+
Attachment #8771999 - Flags: approval-mozilla-aurora?
Attachment #8771999 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
Verified fixed FX 50.0a1 (2016-07-20) Win 7
Flags: needinfo?(paul.silaghi)
Verified fixed FX 48b10, 49.0a2 (2016-07-25) Win 7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.