1287476 - With 1.0.4 changes, sometimes two pocket pages are opened

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Remove setTimeout, just clear handlers

See:

https://bugzilla.mozilla.org/show_bug.cgi?id=1276054#c23

Found by QA

Comment 1

[Mike Kaply [:mkaply]]

Gijs:

I know you had qualms about the setTimeout in the first place. This is the proper fix, per Pocket.

They had originally had deletes, but those were flagged in strict mode:

https://github.com/mozilla-partners/pocket/pull/3

Comment 2

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/fx-team/rev/7ccf33128023d24884aee9df86a556508b52d482
Bug 1287476 - Clear panel handlers to avoid double page. r=Gijs

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7ccf33128023

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8771999 [details] [diff] [review]
Remove setTimeout, just clear handlers

Approval Request Comment
[Feature/regressing bug #]: Double pages on clicking pocket button
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low
[String/UUID change made/needed]: None

This new code is already in aurora/beta. Would be nice to get this fix in there as well.

Comment 5

[:Gijs (he/him)]

Paul, can you verify that this issue is now resolved?

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8771999 [details] [diff] [review]
Remove setTimeout, just clear handlers

Review of attachment 8771999 [details] [diff] [review]:
-----------------------------------------------------------------

We'll have 48 beta 10 to fix the potential regressions. And, in the future, please fill the section of the template about testing (btw, "[Feature/regressing bug #]" is incorrect). Let's take it in 48 beta 10 and aurora.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/44d69ae6d469

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e887ad7d5eb

Comment 9

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 50.0a1 (2016-07-20) Win 7

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 48b10, 49.0a2 (2016-07-25) Win 7