Closed Bug 1287536 Opened 8 years ago Closed 7 years ago

__heartbeat__ should return a 502 with a useful error message, instead of an empty 500

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: anjul.ten)

References

Details

(Whiteboard: [lang=python][ready][good first bug]) 

We hit an issue with the first push to the new Balrog stage today. The underlying issue was with the connection to the db, but it was impossible to tell without diving deep into server logs. Benson says:
14:19 <mostlygeek> so... __heartbeat__ should 502 with a useful error message 
14:19 <mostlygeek> that way if the site is down, we can use it to troubleshoot why


Perhaps we can return a stack trace of the original exception instead?
Priority: -- → P3
Whiteboard: [lang=python][ready]
We need to be careful not to leak any internal information (db password - stuff like that), if we return the original Exception.
Whiteboard: [lang=python][ready] → [lang=python][ready][good first bug]
I'm trying to fix this one.
Assignee: nobody → anjul.ten
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/d14001b37d3080edc06561986b1b068752501b29
Bug: 1287536. Returning the exceptions from __heartbeat with 502 and a message. r=bhearsum. (#274).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1351688
This is now in production. Thank you Anjul!
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.