Touch-action hit-test doesn't account for resolution on Fennec

RESOLVED FIXED in Firefox 50

Status

()

Core
Panning and Zooming
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

50 Branch
mozilla50
All
Android
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: gfx-noted)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

The call at [1] is supposed to remove the resolution from the provided point, but it doesn't. It doesn't because it picks up the resolution from the root document rather than the root content document, so I think we need to add code similar to [2] on this code path.

[1] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/gfx/layers/apz/util/TouchActionHelper.cpp#59
[2] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/gfx/layers/apz/util/APZCCallbackHelper.cpp#567
Created attachment 8773854 [details]
Bug 1287576 - Change namespace and do some formatting cleanup for TouchActionHelper.

Review commit: https://reviewboard.mozilla.org/r/66512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66512/
Attachment #8773854 - Flags: review?(botond)
Attachment #8773855 - Flags: review?(botond)
Attachment #8773856 - Flags: review?(botond)
Created attachment 8773855 [details]
Bug 1287576 - Extract a helper method to update a frame to the touch target document's root frame. No functional changes.

Review commit: https://reviewboard.mozilla.org/r/66514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66514/
Created attachment 8773856 [details]
Bug 1287576 - Update the touch-behavior notification code to behave like the set-target-apzc notification code.

In particular, this change uses the root frame of the touch target document,
so that the correct presShell resolution is used when doing the touch-action
hit test.

Review commit: https://reviewboard.mozilla.org/r/66516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66516/
Comment on attachment 8773854 [details]
Bug 1287576 - Change namespace and do some formatting cleanup for TouchActionHelper.

https://reviewboard.mozilla.org/r/66512/#review63704
Attachment #8773854 - Flags: review?(botond) → review+
Comment on attachment 8773855 [details]
Bug 1287576 - Extract a helper method to update a frame to the touch target document's root frame. No functional changes.

https://reviewboard.mozilla.org/r/66514/#review63708
Attachment #8773855 - Flags: review?(botond) → review+
Comment on attachment 8773856 [details]
Bug 1287576 - Update the touch-behavior notification code to behave like the set-target-apzc notification code.

https://reviewboard.mozilla.org/r/66516/#review63710
Attachment #8773856 - Flags: review?(botond) → review+

Comment 8

2 years ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c01c25609d
Change namespace and do some formatting cleanup for TouchActionHelper. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/77c13c4140a4
Extract a helper method to update a frame to the touch target document's root frame. No functional changes. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/5adee976c6cc
Update the touch-behavior notification code to behave like the set-target-apzc notification code. r=botond

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a6c01c25609d
https://hg.mozilla.org/mozilla-central/rev/77c13c4140a4
https://hg.mozilla.org/mozilla-central/rev/5adee976c6cc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.