1287593 - add create-db command to run.sh

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

We rebuilt stage this morning, and it would've been very helpful to have a target in run.sh that creates a db and optionally populates it with some data. Having this would avoid the need to override the entrypoint.

Comment 1

[harsh shah]

I would like to work on this bug.I am very new to open source(this is my very first bug) so can you guide me how to go about it.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to harsh shah from comment #1)
> I would like to work on this bug.I am very new to open source(this is my
> very first bug) so can you guide me how to go about it.

Hi Harsh, thanks for your interest here! The first thing you'll want to do is fork the Balrog repo (https://github.com/mozilla/balrog), clone it locally, and make sure you can run all the tests succesfully. Once you have your local repo, try running "run-test.sh" and make sure it passes.

If you have any trouble getting set-up feel free to e-mail me, or ask in irc://irc.mozilla.org/#balrog.

Comment 3

[meet123mangukiya]

I would like to work on this bug, I've cloned the balrog repo, and the tests passed, what next has to be done? First-timer at bug fixing and also first-timer at mozilla.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to meet123mangukiya from comment #3)
> I would like to work on this bug, I've cloned the balrog repo, and the tests
> passed, what next has to be done? First-timer at bug fixing and also
> first-timer at mozilla.

I'd like to give Harsh a few more days to respon before reassigning this. If you'd like to look at something in the meantime, https://bugzilla.mozilla.org/show_bug.cgi?id=1281459 or https://bugzilla.mozilla.org/show_bug.cgi?id=1270827 would be good choices.

Comment 5

[deep.red.rosie.999]

I'd like to work on this bug. I am decent at shell scripting and I'm ready to learn. :)

Any pointers?

Comment 6

[[e-mail] (:bhearsum)]

(In reply to deep.red.rosie.999 from comment #5)
> I'd like to work on this bug. I am decent at shell scripting and I'm ready
> to learn. :)
> 
> Any pointers?

https://github.com/mozilla/balrog/blob/master/uwsgi/run.sh is the file referenced by the bug title. What we need is a section similar to "upgrade-db" that initializes an empty db instead. This will probably be a matter of calling out to https://github.com/mozilla/balrog/blob/master/scripts/manage-db.py, which already knows how to create the database.

This is a bit trickier to test than some things. First of all, you'll need a virtualenv with Balrog installed, eg:
git clone https://github.com/mozilla/balrog
cd balrog
virtualenv -p /usr/bin/python2.7 venv
source venv/bin/activate
python setup.py develop

When this is fixed correctly, we should be able to run commands such as:
DBURI=sqlite:///tmp/foo.db bash uwsgi/run.sh upgrade-db

...and end up with a fully initialized database in /tmp/foo.db.

--

I know this may be a lot to take in, so feel free to e-mail me or ask in irc://irc.mozilla.org/#balrog if you have any questions.

Comment 7

[[e-mail] (:bhearsum)]

Did you make an progress?

Comment 8

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #7)
> Did you make an progress?

It looks like you're not working on this. I'm going to unassign it for now. Please let me know if you still want to give it a try.

Comment 9

[Tomislav Jurin]

Is this still open?

Comment 10

[nhuang]

Attachment: Patch to add create-db in run.sh

Hi, I created a patch to add create-db to run.sh. Tested out with `DBURI=sqlite:///foo.db bash scripts/run.sh create-db` and verified that foo.db is created, and checked that run-tests.sh passes for all tests

Comment 11

[[e-mail] (:bhearsum)]

(In reply to nhuang from comment #10)
> Created attachment 8812093 [details] [diff] [review]
> Patch to add create-db in run.sh
> 
> Hi, I created a patch to add create-db to run.sh. Tested out with
> `DBURI=sqlite:///foo.db bash scripts/run.sh create-db` and verified that
> foo.db is created, and checked that run-tests.sh passes for all tests

This looks good - if you have a Github account, could you send it as a Pull Request to https://github.com/mozilla/balrog?

Comment 12

[nhuang]

(In reply to Ben Hearsum (:bhearsum) from comment #11)
> (In reply to nhuang from comment #10)
> > Created attachment 8812093 [details] [diff] [review]
> > Patch to add create-db in run.sh
> > 
> > Hi, I created a patch to add create-db to run.sh. Tested out with
> > `DBURI=sqlite:///foo.db bash scripts/run.sh create-db` and verified that
> > foo.db is created, and checked that run-tests.sh passes for all tests
> 
> This looks good - if you have a Github account, could you send it as a Pull
> Request to https://github.com/mozilla/balrog?

Sure, will do this tonight

Comment 13

[nhuang]

(In reply to nhuang from comment #12)
> (In reply to Ben Hearsum (:bhearsum) from comment #11)
> > (In reply to nhuang from comment #10)
> > > Created attachment 8812093 [details] [diff] [review]
> > > Patch to add create-db in run.sh
> > > 
> > > Hi, I created a patch to add create-db to run.sh. Tested out with
> > > `DBURI=sqlite:///foo.db bash scripts/run.sh create-db` and verified that
> > > foo.db is created, and checked that run-tests.sh passes for all tests
> > 
> > This looks good - if you have a Github account, could you send it as a Pull
> > Request to https://github.com/mozilla/balrog?
> 
> Sure, will do this tonight

Pull request sent

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6ad44d54f1fd07b266d3024113ab607be4b7af0a
bug 1287593: Add create-db command to run.sh (#180). r=bhearsum

Comment 15

[[e-mail] (:bhearsum)]

Normally we wait until things are in production to close the bugs, but this is fine :) - just correcting the resolution.

Comment 16

[nhuang]

(In reply to Ben Hearsum (:bhearsum) from comment #15)
> Normally we wait until things are in production to close the bugs, but this
> is fine :) - just correcting the resolution.

Oh oops thought it was in prod sorry :(

Comment 17

[Rail Aliiev [:rail]]

This change will be deployed in bug 1320966 sometime between 11am and 1pm pacific on 2016-11-30. IT will be deployed to stage today. Can you verify your fixes once stage is deployed please?

Comment 18

[[e-mail] (:bhearsum)]

There's nothing here that can be verified in stage.