Closed Bug 1287631 Opened 5 years ago Closed 5 years ago

Services.appInfo is spelled incorrectly (should be using Services.appinfo)

Categories

(DevTools :: Memory, defect)

47 Branch
defect
Not set
normal

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: robwu, Assigned: tromey)

References

Details

Attachments

(1 file)

Bug 1201597 and bug 1207645 introduce code [1] [2] that uses Services.appInfo. This is not defined in Services.jsm, you should be using Services.appinfo instead (with a lowercase i).

I suggest to either remove the code, or fix the typo and add unit tests to assure that whatever you expected really happens.

[1] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/devtools/shared/heapsnapshot/tests/unit/head_heapsnapshot.js#32
[2] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/devtools/server/actors/heap-snapshot-file.js#28
It's not clear to me that :fitzgen actually intends to work on this, clearing assignee for now.  Apologies if I am in error!
Assignee: nfitzgerald → nobody
I imagine the clause "Services.appInfo &&" is there just to deal with the typo,
and that removing this will keep the code doing the right thing.
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Comment on attachment 8778249 [details]
Bug 1287631 - fix typo in Services.appinfo use in devtools;

https://reviewboard.mozilla.org/r/69560/#review66726

Thanks!
Attachment #8778249 - Flags: review?(nfitzgerald) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39e383238584
fix typo in Services.appinfo use in devtools; r=fitzgen
https://hg.mozilla.org/mozilla-central/rev/39e383238584
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.