1287631 - Services.appInfo is spelled incorrectly (should be using Services.appinfo)

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Rob Wu [:robwu]]

Bug 1201597 and bug 1207645 introduce code [1] [2] that uses Services.appInfo. This is not defined in Services.jsm, you should be using Services.appinfo instead (with a lowercase i).

I suggest to either remove the code, or fix the typo and add unit tests to assure that whatever you expected really happens.

[1] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/devtools/shared/heapsnapshot/tests/unit/head_heapsnapshot.js#32
[2] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/devtools/server/actors/heap-snapshot-file.js#28

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It's not clear to me that :fitzgen actually intends to work on this, clearing assignee for now.  Apologies if I am in error!

Comment 3

[Tom Tromey :tromey]

I imagine the clause "Services.appInfo &&" is there just to deal with the typo,
and that removing this will keep the code doing the right thing.

Comment 4

[Tom Tromey :tromey]

Attachment: Bug 1287631 - fix typo in Services.appinfo use in devtools;

Review commit: https://reviewboard.mozilla.org/r/69560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69560/

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8778249 [details]
Bug 1287631 - fix typo in Services.appinfo use in devtools;

https://reviewboard.mozilla.org/r/69560/#review66726

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39e383238584
fix typo in Services.appinfo use in devtools; r=fitzgen

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/39e383238584