Closed Bug 1287631 Opened 5 years ago Closed 5 years ago
.app Info is spelled incorrectly (should be using Services .appinfo)
58 bytes, text/x-review-board-request
Bug 1201597 and bug 1207645 introduce code   that uses Services.appInfo. This is not defined in Services.jsm, you should be using Services.appinfo instead (with a lowercase i). I suggest to either remove the code, or fix the typo and add unit tests to assure that whatever you expected really happens.  http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/devtools/shared/heapsnapshot/tests/unit/head_heapsnapshot.js#32  http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/devtools/server/actors/heap-snapshot-file.js#28
Duplicate of this bug: 1291428
It's not clear to me that :fitzgen actually intends to work on this, clearing assignee for now. Apologies if I am in error!
Assignee: nfitzgerald → nobody
I imagine the clause "Services.appInfo &&" is there just to deal with the typo, and that removing this will keep the code doing the right thing.
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/69560/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69560/
Attachment #8778249 - Flags: review?(nfitzgerald)
Comment on attachment 8778249 [details] Bug 1287631 - fix typo in Services.appinfo use in devtools; https://reviewboard.mozilla.org/r/69560/#review66726 Thanks!
Attachment #8778249 - Flags: review?(nfitzgerald) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/39e383238584 fix typo in Services.appinfo use in devtools; r=fitzgen
You need to log in before you can comment on or make changes to this bug.