interdiff can mask some changes

NEW
Unassigned

Status

MozReview
General
2 years ago
2 years ago

People

(Reporter: glandium, Unassigned)

Tracking

Details

(Reporter)

Description

2 years ago
See https://reviewboard.mozilla.org/r/62468/diff/

The interdiff between revision 1 and 2 doesn't show the removal of the block in android.m4 that starts with "dnl Not all Android releases have their own platform release. We use".

What happened is, essentially:
- Patch revision 1 was against revision A of android.m4
- Patch revision 2 was against revision B of android.m4
- The diff between revision A of android.m4 and revision B of android.m4 added the block starting with "dnl Not all Android releases have their own platform release. We use".
- Those added lines are relevant to the second patch revision, and the second patch revision rightfully deletes them (adding corresponding code to android-ndk.configure).
- The interdiff between patch revision 1 and revision 2 doesn't show the deletion. Which is kind of obvious considering the lines weren't there in the first place. But it's still something interesting to the reviewer looking at the interdiff, but can't easily be represented. As discussed at Mozlondon, an intermediate rebased patch revision 1 would help in such cases.
You need to log in before you can comment on or make changes to this bug.