Closed Bug 1287670 Opened 4 years ago Closed 4 years ago
Improve cohesion of MDSM::Initiate
58 bytes, text/x-review-board-request
|SetState(DECODER_STATE_SEEKING)| always appear before InitiateSeek() which means they are tightly coupled. Also we can move |mCurrentSeek.mPromise.Ensure| into InitiateSeek() to make the function more useful and functional.
Assignee: nobody → jwwang
Priority: -- → P3
Review commit: https://reviewboard.mozilla.org/r/65408/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65408/
Attachment #8772656 - Flags: review?(kaku)
Comment on attachment 8772656 [details] Bug 1287670 - Improve cohesion of MDSM::InitiateSeek(). https://reviewboard.mozilla.org/r/65408/#review62448 ::: dom/media/MediaDecoderStateMachine.cpp:1639 (Diff revision 1) > // Stop playback now to ensure that while we're outside the monitor > // dispatching SeekingStarted, playback doesn't advance and mess with > // mCurrentPosition that we've setting to seekTime here. > StopPlayback(); > > // mCurrentSeek.mTarget.mTime might be different from The comment here should also be updated.
Attachment #8772656 - Flags: review?(kaku) → review+
https://reviewboard.mozilla.org/r/65408/#review62448 > The comment here should also be updated. Will do. Thanks for the review!
Comment on attachment 8772656 [details] Bug 1287670 - Improve cohesion of MDSM::InitiateSeek(). Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65408/diff/1-2/
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9417053b8680 Improve cohesion of MDSM::InitiateSeek(). r=kaku
You need to log in before you can comment on or make changes to this bug.