1287682 - Got assertion failure when running generated/test_2_conformance2__textures__misc__texture-npot.html

Status: NEW

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Peter Chang[:pchang]]

I got assertion on MAC with AMD GPU, but chrome doesn't have this problem.

BTW this test got passed on my another WIN with NV GPU.


Assertion failure: false (GFX: We should have caught all other errors.), at /Users/peter/code/gecko/dom/canvas/WebGLTextureUpload.cpp:2050
#01: _ZN7mozilla12WebGLContext14CopyTexImage2DEjijiiiii[/Users/peter/code/obj-browser-gecko-NOOPT/dist/Nightly.app/Contents/MacOS/XUL +0x34bbb59]
#02: _ZN7mozilla3dom28WebGLRenderingContextBindingL14copyTexImage2DEP9JSContextN2JS6HandleIP8JSObjectEEPNS_12WebGLContextERK19JSJitMethodCallArgs[/Users/peter/code/obj-browser-gecko-NOOPT/dist/Nightly.app/Contents/MacOS/XUL +0x2e33422]
#03: _ZN7mozilla3dom20GenericBindingMethodEP9JSContextjPN2JS5ValueE[/Users/peter/code/obj-browser-gecko-NOOPT/dist/Nightly.app/Contents/MacOS/XUL +0x33b6ad2]
#04: _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE[/Users/peter/code/obj-browser-gecko-NOOPT/dist/Nightly.app/Contents/MacOS/XUL +0x70932a9]
#05: _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE[/Users/peter/code/obj-browser-gecko-NOOPT/dist/Nightly.app/Contents/MacOS/XUL +0x70935b2]
#06: _ZN2js13CallFromStackEP9JSContextRKN2JS8CallArgsE[/Users/peter/code/obj-browser-gecko-NOOPT/dist/Nightly.app/Contents/MacOS/XUL +0x709343d]

Comment 1

[Peter Chang[:pchang]]

I got GL_INVALID_ENUM(0x500) on my Mac with Intel or AMD GPU.

Comment 2

[Peter Chang[:pchang]]

After OpenGL 4.1, all ALPHA, LUMINANCE , LUMINANCE_ALPHA are legacy pixel formats. Therefore, we need a workaround for OpenGL 4.1 with WebGL 2.

Comment 3

[Peter Chang[:pchang]]

Attachment: Bug 1287682 - Support legacy formats with CopyTexImage2D API.

Review commit: https://reviewboard.mozilla.org/r/66378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66378/

Comment 4

[Peter Chang[:pchang]]

Attachment: Bug 1287682 - Add test case for CopyTexImage2D with legacy format,

Review commit: https://reviewboard.mozilla.org/r/66380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66380/

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8773635 [details]
Bug 1287682 - Support legacy formats with CopyTexImage2D API.

https://reviewboard.mozilla.org/r/66378/#review63468

Those setting only works for LUMINANCE. For ALPHA and LUMINANCE_ALPHA, this is wrong. I believe the test case didn't examine the result of glCopyTexImage so the test case is pass but I think the actual result is wrong. I think we should examine the result of glCopyTexImage in test case as well.

Comment 6

[Peter Chang[:pchang]]

Attachment: Bug 1287682 - enable testing under checkout/conformance2/textures/misc,

Review commit: https://reviewboard.mozilla.org/r/69238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69238/

Comment 7

[Peter Chang[:pchang]]

Comment on attachment 8773635 [details]
Bug 1287682 - Support legacy formats with CopyTexImage2D API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66378/diff/1-2/

Comment 8

[Peter Chang[:pchang]]

Comment on attachment 8773636 [details]
Bug 1287682 - Add test case for CopyTexImage2D with legacy format,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66380/diff/1-2/

Comment 9

[Peter Chang[:pchang]]

I tried to enable tests under checkout/conformance2/texture/misc, but got lots of failures. After checking, it was not related to my patch. Will create another bug to address them.

Comment 10

[Peter Chang[:pchang]]

Comment on attachment 8773636 [details]
Bug 1287682 - Add test case for CopyTexImage2D with legacy format,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66380/diff/2-3/

Comment 11

[Peter Chang[:pchang]]

Comment on attachment 8777765 [details]
Bug 1287682 - enable testing under checkout/conformance2/textures/misc,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69238/diff/1-2/

Comment 12

[Peter Chang[:pchang]]

https://reviewboard.mozilla.org/r/66378/#review63468

This bug was already addressed at 1290634

Comment 13

[Peter Chang[:pchang]]

Comment on attachment 8773635 [details]
Bug 1287682 - Support legacy formats with CopyTexImage2D API.

https://reviewboard.mozilla.org/r/66376/#review67078