Closed Bug 1287684 Opened 3 years ago Closed 3 years ago

Report HTMLMediaElement telemetry in non-MSE case

Categories

(Core :: Audio/Video: Playback, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

As per bug 1270614 comment 0, "ReportMSETelemetry() is no longer MSE-specific. It should be renamed to reflect this."
However renaming it was not enough, it is currently still stuck in an 'if(mMediaSource)' block, so it only runs it when using MSE.
We should just get rid of that test.
Removed test blocking execution of ReportTelemetry in non-MSE case.

EME currently depends on MSE, so ReportEMETelemetry won't do anything in the
non-MSE case anyway. But I think it's good to remove the MSE test as well, in
case we change that limitation in the future.

Review commit: https://reviewboard.mozilla.org/r/65136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65136/
Attachment #8772287 - Flags: review?(giles)
Comment on attachment 8772287 [details]
Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE -

https://reviewboard.mozilla.org/r/65136/#review62342

Thanks for the follow-up.
Attachment #8772287 - Flags: review?(giles) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b135c0869e1
Report HTMLMediaElement telemetry for non-MSE - r=rillian
https://hg.mozilla.org/mozilla-central/rev/1b135c0869e1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Summary: Report HTMLMediaElement in non-MSE case → Report HTMLMediaElement telemetry in non-MSE case
Depends on: 1307616
You need to log in before you can comment on or make changes to this bug.