1287684 - Report HTMLMediaElement telemetry in non-MSE case

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

As per bug 1270614 comment 0, "ReportMSETelemetry() is no longer MSE-specific. It should be renamed to reflect this."
However renaming it was not enough, it is currently still stuck in an 'if(mMediaSource)' block, so it only runs it when using MSE.
We should just get rid of that test.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE -

Removed test blocking execution of ReportTelemetry in non-MSE case.

EME currently depends on MSE, so ReportEMETelemetry won't do anything in the
non-MSE case anyway. But I think it's good to remove the MSE test as well, in
case we change that limitation in the future.

Review commit: https://reviewboard.mozilla.org/r/65136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65136/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=170563b2001012e1fc7954f22f24ca3053c9c5e1

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8772287 [details]
Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE -

https://reviewboard.mozilla.org/r/65136/#review62342

Thanks for the follow-up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b135c0869e1
Report HTMLMediaElement telemetry for non-MSE - r=rillian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b135c0869e1