Report HTMLMediaElement telemetry in non-MSE case

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gerald, Assigned: gerald)

Tracking

50 Branch
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
As per bug 1270614 comment 0, "ReportMSETelemetry() is no longer MSE-specific. It should be renamed to reflect this."
However renaming it was not enough, it is currently still stuck in an 'if(mMediaSource)' block, so it only runs it when using MSE.
We should just get rid of that test.
(Assignee)

Comment 1

2 years ago
Created attachment 8772287 [details]
Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE -

Removed test blocking execution of ReportTelemetry in non-MSE case.

EME currently depends on MSE, so ReportEMETelemetry won't do anything in the
non-MSE case anyway. But I think it's good to remove the MSE test as well, in
case we change that limitation in the future.

Review commit: https://reviewboard.mozilla.org/r/65136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65136/
Attachment #8772287 - Flags: review?(giles)
Comment on attachment 8772287 [details]
Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE -

https://reviewboard.mozilla.org/r/65136/#review62342

Thanks for the follow-up.
Attachment #8772287 - Flags: review?(giles) → review+

Comment 4

2 years ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b135c0869e1
Report HTMLMediaElement telemetry for non-MSE - r=rillian

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b135c0869e1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Updated

2 years ago
Summary: Report HTMLMediaElement in non-MSE case → Report HTMLMediaElement telemetry in non-MSE case
(Assignee)

Updated

2 years ago
Depends on: 1307616
You need to log in before you can comment on or make changes to this bug.