1287698 - Make MDSM::mPendingDormant a bool

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

A bool will do the job. We don't need a Maybe<bool>.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1287698 - Make MDSM::mPendingDormant a bool.

Review commit: https://reviewboard.mozilla.org/r/65154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65154/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8772305 [details]
Bug 1287698 - Make MDSM::mPendingDormant a bool.

https://reviewboard.mozilla.org/r/65154/#review62192

::: dom/media/MediaDecoderStateMachine.cpp:1198
(Diff revision 1)
>      // reset state, and put a ResetDecode in the decode task queue. Any tasks
>      // that run after ResetDecode are supposed to run with a clean slate. We rely
>      // on that in other places (i.e. seeking), so it seems reasonable to rely on
>      // it here as well.
>      mReader->ReleaseMediaResources();
>    } else if ((aDormant != true) && (mState == DECODER_STATE_DORMANT)) {

aDormant != true is redundant, it will always be true ; plus it's not moz coding style.

may as well change it while there.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/65154/#review62192

> aDormant != true is redundant, it will always be true ; plus it's not moz coding style.
> 
> may as well change it while there.

Will do. Thanks for the review!

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8772305 [details]
Bug 1287698 - Make MDSM::mPendingDormant a bool.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65154/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91afa84e2001
Make MDSM::mPendingDormant a bool. r=jya

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91afa84e2001