1287712 - TimeDurationAccumulator reports should include running timer

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

In the current implementation of TimeDurationAccumulator, Total() and Count() return the total duration and count of segments so far, but if the timer is currently running (i.e., not Pause()'d) the currently-running segment is not counted.
This could mean that the recorded play time may be wrong if the timer was not properly paused before telemetry was collected!

It should be easy to add the running timer (without pausing).

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1287712 - TimeDurationAccumulator includes running timer in reports -

If the timer is currently running, add started time segment until now to
Total(), and add 1 to Count().
This ensures correct values are returned without having to Pause().

Review commit: https://reviewboard.mozilla.org/r/65158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65158/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8772325 [details]
Bug 1287712 - TimeDurationAccumulator includes running timer in reports -

https://reviewboard.mozilla.org/r/65158/#review62636

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd2f39397641
TimeDurationAccumulator includes running timer in reports - r=cpearce

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd2f39397641