Drop KeyframeEffectReadOnly::HasAnimationOfProperties and nsLayoutUtils::HasCurrentAnimationsForProperties.

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There is a only one place we call nsLayoutUtils::HasCurrentAnimationsForProperties.
http://hg.mozilla.org/mozilla-central/file/feaaf1af1065/layout/base/ActiveLayerTracker.cpp#l449

As you can see, it essentially same as nsLayoutUtils::HasCurrentAnimationOfProperty.
It turns out that this bug does not block bug 1287725 at all.  I thought nsLayoutUtils::HasCurrentAnimationsForProperties() in ActiveLayerTracker::IsStyleAnimated() will be replaced by nsLayoutUtils::HasRelevantAnimationOfProperty() in bug 1287725, but ActiveLayerTracker::IsStyleAnimated() is called from ActiveLayerTracker::IsBackgroundPositionAnimated(), yes, it's for non-compositable properties. So, we won't replace it in bug 1287725.
No longer blocks: 1223658
I thought I did request review for the patch here...
Created attachment 8774507 [details]
Bug 1287725 - Drop KeyframeEffectReadOnly::HasAnimationOfProperties and nsLayoutUtils::HasCurrentAnimationsForProperties.

Review commit: https://reviewboard.mozilla.org/r/65196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65196/
Attachment #8774507 - Flags: review?(bbirtles)
Comment on attachment 8774507 [details]
Bug 1287725 - Drop KeyframeEffectReadOnly::HasAnimationOfProperties and nsLayoutUtils::HasCurrentAnimationsForProperties.

https://reviewboard.mozilla.org/r/65196/#review63884
Attachment #8774507 - Flags: review?(bbirtles) → review+

Comment 6

2 years ago
Pushed by hiikezoe@mozilla-japan.org:
https://hg.mozilla.org/integration/autoland/rev/5125ae09224a
Drop KeyframeEffectReadOnly::HasAnimationOfProperties and nsLayoutUtils::HasCurrentAnimationsForProperties. r=birtles

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5125ae09224a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.