Closed Bug 1287760 Opened 3 years ago Closed 3 years ago

Comment out AddEventListenerOptions.once

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox-esr45 --- fixed
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

Attached patch once.patchSplinter Review
No description provided.
Attachment #8772388 - Flags: review?(bugs)
Comment on attachment 8772388 [details] [diff] [review]
once.patch

And one ESR we need also passive commented out, right?

It was implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1266066
Attachment #8772388 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bfa8f091fcc
Comment out AddEventListenerOptions.once, r=smaug
Attached patch esr-45Splinter Review
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: feature detection.
Fix Landed on Version: current m-i
Risk to taking this patch (and alternatives if risky):  none
String or UUID changes made by this patch:  none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8772400 - Flags: approval-mozilla-esr45?
We need the patch on 49 too.
Errr... I mean how can a field of dictionary be feature-detectable?
 document.addEventListener("foo", function() {}, { get once() { throw "foo" }});
https://hg.mozilla.org/mozilla-central/rev/7bfa8f091fcc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Baku, I am sorry but I need subtitle to understand why you want this into esr as his is not a sec issue.
Flags: needinfo?(amarchesini)
Smaug, can you help me with this?
Flags: needinfo?(amarchesini) → needinfo?(bugs)
We broke feature testing on esr (and elsewhere) when landing the patch which didn't have review comments fixed
https://bugzilla.mozilla.org/show_bug.cgi?id=1266194#c5
Flags: needinfo?(bugs)
Comment on attachment 8772400 [details] [diff] [review]
esr-45

Improve the webcompat support of esr45, taking it.
Attachment #8772400 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.