Comment out AddEventListenerOptions.once

RESOLVED FIXED in Firefox -esr45

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

50 Branch
mozilla50
Points:
---

Firefox Tracking Flags

(firefox-esr45 fixed, firefox50 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8772388 [details] [diff] [review]
once.patch
Attachment #8772388 - Flags: review?(bugs)

Comment 1

2 years ago
Comment on attachment 8772388 [details] [diff] [review]
once.patch

And one ESR we need also passive commented out, right?

It was implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1266066
Attachment #8772388 - Flags: review?(bugs) → review+

Comment 2

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bfa8f091fcc
Comment out AddEventListenerOptions.once, r=smaug
(Assignee)

Comment 3

2 years ago
Created attachment 8772400 [details] [diff] [review]
esr-45

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: feature detection.
Fix Landed on Version: current m-i
Risk to taking this patch (and alternatives if risky):  none
String or UUID changes made by this patch:  none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8772400 - Flags: approval-mozilla-esr45?

Comment 4

2 years ago
We need the patch on 49 too.
Comment hidden (obsolete)
Errr... I mean how can a field of dictionary be feature-detectable?

Comment 7

2 years ago
 document.addEventListener("foo", function() {}, { get once() { throw "foo" }});

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7bfa8f091fcc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Baku, I am sorry but I need subtitle to understand why you want this into esr as his is not a sec issue.
Flags: needinfo?(amarchesini)
(Assignee)

Comment 10

2 years ago
Smaug, can you help me with this?
Flags: needinfo?(amarchesini) → needinfo?(bugs)
We broke feature testing on esr (and elsewhere) when landing the patch which didn't have review comments fixed
https://bugzilla.mozilla.org/show_bug.cgi?id=1266194#c5
Flags: needinfo?(bugs)
status-firefox-esr45: --- → affected
Comment on attachment 8772400 [details] [diff] [review]
esr-45

Improve the webcompat support of esr45, taking it.
Attachment #8772400 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
https://hg.mozilla.org/releases/mozilla-esr45/rev/6b17b640955d
status-firefox-esr45: affected → fixed
You need to log in before you can comment on or make changes to this bug.