Closed
Bug 1287785
Opened 9 years ago
Closed 9 years ago
avoid copying ScrollMetadata values in RenderLayers
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
1.11 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
Using `auto' here means that we're copying each ScrollMetadata value as
we examine it. Using `auto&' here means that we don't copy, which is
probably the intended behavior.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8772398 -
Flags: review?(botond)
Comment 2•9 years ago
|
||
Comment on attachment 8772398 [details] [diff] [review]
avoid copying ScrollMetadata values in RenderLayers
Review of attachment 8772398 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/composite/ContainerLayerComposite.cpp
@@ +598,5 @@
> continue;
> }
>
> if (gfxPrefs::LayersDrawFPS()) {
> + for (auto& metadata : layer->GetAllScrollMetadata()) {
Might as well use |const auto&|, to indicate the loop doesn't modify the metadata objects.
Attachment #8772398 -
Flags: review?(botond) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/920b164008c2
avoid copying ScrollMetadata values in RenderLayers; r=botond
Comment 4•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•