1287785 - avoid copying ScrollMetadata values in RenderLayers

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nathan Froyd [:froydnj]]

Using `auto' here means that we're copying each ScrollMetadata value as
we examine it.  Using `auto&' here means that we don't copy, which is
probably the intended behavior.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: avoid copying ScrollMetadata values in RenderLayers

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8772398 [details] [diff] [review]
avoid copying ScrollMetadata values in RenderLayers

Review of attachment 8772398 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/ContainerLayerComposite.cpp
@@ +598,5 @@
>        continue;
>      }
>  
>      if (gfxPrefs::LayersDrawFPS()) {
> +      for (auto& metadata : layer->GetAllScrollMetadata()) {

Might as well use |const auto&|, to indicate the loop doesn't modify the metadata objects.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/920b164008c2
avoid copying ScrollMetadata values in RenderLayers; r=botond

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/920b164008c2