Change the export of the l10n files to merge the beta changes

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sylvestre, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

PR
49 bytes, text/x-github-pull-request
jlorenzo
: review+
rail
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
Implemented in https://github.com/mozilla-releng/ship-it/pull/71
For now, we have a file per beta ( http://127.0.0.1:5000/json/l10n/Firefox-32.0b1-build1.json )
containing:
{"version": 1, "locales": {"zh-TW": {"changeset": "c5333e78fa1d"}, "pa-IN": {"changeset": "6758aad72236"}, "gd": {"changeset": "1d183d714456"}, "gl": {"changeset": "3676dfac7743"}, "en-GB": {"changeset": "a63de949e0d7"}, "tr": {"changeset": "15e4012ae9a7"}, "lv": {"changeset": "3efcbe96f5be"}, "lt": {"changeset": "def7c3341f63"}, "th": {"changeset": "03c6f45c9979"}, "te": {"changeset": "4734e5e77d52"}, "ta": {"changeset": "9abd18a1b85b"}, "bn-IN": {"changeset": "af9c10e38a6c"}, "de": {"changeset": "15ce95bbc988"}, "ko": {"changeset": "4cadbc5439fb"}, "da": {"changeset": "8170d371be7b"}, "pt-BR": {"changeset": "2eb6f7c52561"}, "nb-NO": {"changeset": "04872aa15b78"}, "gu-IN": {"changeset": "c3c484b14d6e"}, "ga-IE": {"changeset": "809acd38d181"}, "es-CL": {"changeset": "3389e7e0192f"}, "el": {"changeset": "22b959c9a739"}, "eo": {"changeset": "f12d79467b00"}, "eu": {"changeset": "1a522c0b8b33"}, "sv-SE": {"changeset": "e2699bb71688"}, "ru": {"changeset": "6e434f9f03cf"}, "rm": {"changeset": "e70b835e3270"}, "ro": {"changeset": "cd2cad15a260"}, "dsb": {"changeset": "0ebf2dc5d912"}, "hsb": {"changeset": "a300b974e611"}, "be": {"changeset": "b4c9f7da6ac6"}, "bg": {"changeset": "53c265a34db2"}, "uk": {"changeset": "15316c48fbaf"}, "ast": {"changeset": "4c58edaa081d"}, "br": {"changeset": "b7faed5eb5af"}, "bs": {"changeset": "8fc6fcbbced3"}, "ja": {"changeset": "66d4d9534e2e"}, "hy-AM": {"changeset": "07a71b1815e7"}, "pt-PT": {"changeset": "556cc7aa7984"}, "es-AR": {"changeset": "3a78bfbce239"}, "ach": {"changeset": "c82e296b5f01"}, "nn-NO": {"changeset": "a69a9a650ebf"}, "fy-NL": {"changeset": "79b83fe27b53"}, "or": {"changeset": "a7142f872ba4"}, "ja-JP-mac": {"changeset": "213feba34970"}, "xh": {"changeset": "7d88d1363dab"}, "ca": {"changeset": "30ed224d3321"}, "son": {"changeset": "33685c4602c1"}, "cy": {"changeset": "5b4419b5d8cc"}, "cs": {"changeset": "434f71ab580d"}, "hi-IN": {"changeset": "2cced88d2a9e"}, "pl": {"changeset": "cce4d373d9cf"}, "hr": {"changeset": "d80d3115aed0"}, "hu": {"changeset": "a1b46acd4ee3"}, "he": {"changeset": "fb6de4953a84"}, "ml": {"changeset": "8ada92688746"}, "mk": {"changeset": "ffdf2a789185"}, "zh-CN": {"changeset": "0b9964edf617"}, "en-ZA": {"changeset": "3946c7c61d44"}, "ms": {"changeset": "7ae9bcd9c298"}, "mr": {"changeset": "224401f646ed"}, "af": {"changeset": "7195e324d286"}, "vi": {"changeset": "e5e5cef6c0ee"}, "is": {"changeset": "b6040710b8d2"}, "it": {"changeset": "f1c4941ce4fe"}, "an": {"changeset": "4e76bfadf8ea"}, "as": {"changeset": "c8b83699d74a"}, "ar": {"changeset": "4a5e329f391c"}, "bn-BD": {"changeset": "ab9122b22e7b"}, "et": {"changeset": "bf17ccc3f279"}, "es-ES": {"changeset": "d811034806a3"}, "id": {"changeset": "aa70f9f1c6fe"}, "nl": {"changeset": "2fdf34eab56e"}, "lij": {"changeset": "d6d009b4b3e3"}, "csb": {"changeset": "1d7c7a2e3927"}, "zu": {"changeset": "f3aac54b9951"}, "fr": {"changeset": "40736a1d135b"}, "fa": {"changeset": "189c4346605f"}, "ff": {"changeset": "3a7e8b393a23"}, "mai": {"changeset": "2238b9975f69"}, "fi": {"changeset": "54e2a01a7b22"}, "kk": {"changeset": "f246bafb34e4"}, "sr": {"changeset": "30c918adabba"}, "sq": {"changeset": "656d07b8ce4b"}, "sw": {"changeset": "616e58f2db99"}, "kn": {"changeset": "e12cd39c590c"}, "km": {"changeset": "f3e13363d48c"}, "es-MX": {"changeset": "337c8907db85"}, "sk": {"changeset": "8e143c04f0da"}, "si": {"changeset": "371c4bb15732"}, "ku": {"changeset": "a1a811bf17f7"}, "sl": {"changeset": "3c7c10222daf"}}, "submittedAt": "2014-07-22T04:20:35+00:00", "shippedAt": "2014-07-24T00:00:00+00:00"}

Instead, l10n would like to have a file for all beta like:
http://127.0.0.1:5000/json/l10n/Firefox-32.0beta.json


{
    "version": 1,
    {
        "submittedAt": "2016-06-xx",
        "shippedAt": "2016-06-yy",
        "version": "Firefox-32.0b1-build1"
        "locales": {
            "fr": {"changeset": "aaa", "potentialinfo": "info"}
            "en": {"changeset": "bbb", "potentialinfo": "info"}
        }
    },
    {
        "submittedAt": "2016-06-yy",
        "shippedAt": "2016-06-yy",
        "version": "Firefox-32.0b3-build2<"
        "locales": {
            "fr": {"changeset": "ccc", "potentialinfo": "info"}
            "en": {"changeset": "ddd", "potentialinfo": "info"}
        }
    },
    ...
}
One nit: builds should be elements of an array.

{
    "version": 1,
    [
        {
            "submittedAt": "2016-06-xx",
            "shippedAt": "2016-06-yy",
            "version": "Firefox-32.0b1-build1"
            "locales": {
                "fr": {"changeset": "aaa", "potentialinfo": "info"}
                "en": {"changeset": "bbb", "potentialinfo": "info"}
            }
        },
        {
            "submittedAt": "2016-06-yy",
            "shippedAt": "2016-06-yy",
            "version": "Firefox-32.0b3-build2<"
            "locales": {
                "fr": {"changeset": "ccc", "potentialinfo": "info"}
                "en": {"changeset": "ddd", "potentialinfo": "info"}
            }
        },
    ...
    ]
}
(Assignee)

Comment 2

2 years ago
Created attachment 8772858 [details] [review]
PR

The old behavior is still accessible if you give the whole release name. I also left the releases in "betas". This may not be the best name. r?
Assignee: nobody → jlorenzo
Status: NEW → ASSIGNED
Attachment #8772858 - Flags: review?(sledru)
(Reporter)

Updated

2 years ago
Depends on: 1288168
(Assignee)

Comment 3

2 years ago
Comment on attachment 8772858 [details] [review]
PR

Got r+'d by Sylvestre at https://github.com/mozilla-releng/ship-it/pull/77#issuecomment-234286425
Attachment #8772858 - Flags: review?(sledru) → review+
(Assignee)

Comment 4

2 years ago
Comment on attachment 8772858 [details] [review]
PR

Sylvestre informed me that I forgot asking you for a review, :rail. Sorry about that :S
Attachment #8772858 - Flags: review?(rail)
Attachment #8772858 - Flags: review?(rail) → review+
(Assignee)

Comment 5

2 years ago
Landed in master at https://github.com/mozilla-releng/ship-it/commit/5e485d826f26576e5c7f42a1883196d44cd1dbc2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1290446
You need to log in before you can comment on or make changes to this bug.