Closed Bug 1287834 Opened 4 years ago Closed 4 years ago

[mozlint] Specifying specific linter is broken

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

Currently specifying e.g, mach lint --linter flake8 is broken due to a regression.
Comment on attachment 8772442 [details]
Bug 1287834 - [mozlint] Fix regression preventing specific linters from being run,

https://reviewboard.mozilla.org/r/65252/#review62264

::: python/mozlint/mozlint/cli.py:109
(Diff revision 1)
>          else:
>              return []
>          return subprocess.check_output(cmd).split()
>  
>  
> -def find_linters(self, linters=None):
> +def find_linters(linters=None):

Bah! woops, sorry I missed this in the other reviews, heh
Attachment #8772442 - Flags: review?(smacleod) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81925c21719e
[mozlint] Fix regression preventing specific linters from being run, r=smacleod
No worries, I should have noticed this too!
Summary: [mozlint] Specifying specific linter is brokern → [mozlint] Specifying specific linter is broken
https://hg.mozilla.org/mozilla-central/rev/81925c21719e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.