Logging for intercepted COM traffic

RESOLVED FIXED in Firefox 50

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla50
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
This patch facilitates logging of COM traffic in both the parent and sandboxed child processes. It will be used by the forthcoming COM interceptor.
(Assignee)

Comment 1

2 years ago
Created attachment 8772498 [details]
Bug 1287875: Adds a logging facility for intercepted COM traffic;

Review commit: https://reviewboard.mozilla.org/r/65292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65292/
Attachment #8772498 - Flags: review?(jmathies)

Comment 2

2 years ago
Comment on attachment 8772498 [details]
Bug 1287875: Adds a logging facility for intercepted COM traffic;

https://reviewboard.mozilla.org/r/65292/#review62976

Might be nice if we could filter the QI logging from this. I found it occupies 90% of the log data when testing with a touch screen.  Regardless, not going to hold this up for that.
Attachment #8772498 - Flags: review?(jmathies) → review+
(Assignee)

Comment 3

2 years ago
I'll file a followup.

Comment 4

2 years ago
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2eaabe71dd10
Adds a logging facility for intercepted COM traffic; r=jimm

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2eaabe71dd10
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

Comment 6

2 years ago
NS_APP_CONTENT_PROCESS_TEMP_DIR should only be used if MOZ_CONTENT_SANDBOX is set, cfhttps://dxr.mozilla.org/comm-central/source/mozilla/xpcom/io/nsAppDirectoryServiceDefs.h#87.

Currently this is not the case in https://hg.mozilla.org/mozilla-central/rev/2eaabe71dd10#l1.100 (noticed as it is causing failures on c-c).
Flags: needinfo?(aklotz)
(Assignee)

Comment 7

2 years ago
Created attachment 8776077 [details] [diff] [review]
Build fix for when MOZ_CONTENT_SANDBOX is not defined

Whoops. Considering that I initially wrote NS_APP_CONTENT_PROCESS_TEMP_DIR, I should have known better!
Flags: needinfo?(aklotz)
Attachment #8776077 - Flags: review?(haftandilian)
Attachment #8776077 - Flags: review?(haftandilian) → review+
(Assignee)

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a248e721aa179549a8b5a7b78c0ac8fed4603be
Bug 1287875: Don't try to obtain NS_APP_CONTENT_PROCESS_TEMP_DIR unless MOZ_CONTENT_SANDBOX is defined; r=haik

Comment 10

2 years ago
Thanks for the quick fix. We (TB) can now compile again ;-)
You need to log in before you can comment on or make changes to this bug.