|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
This patch facilitates logging of COM traffic in both the parent and sandboxed child processes. It will be used by the forthcoming COM interceptor.
Created attachment 8772498 [details] Bug 1287875: Adds a logging facility for intercepted COM traffic; Review commit: https://reviewboard.mozilla.org/r/65292/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65292/
Attachment #8772498 - Flags: review?(jmathies)
Comment on attachment 8772498 [details] Bug 1287875: Adds a logging facility for intercepted COM traffic; https://reviewboard.mozilla.org/r/65292/#review62976 Might be nice if we could filter the QI logging from this. I found it occupies 90% of the log data when testing with a touch screen. Regardless, not going to hold this up for that.
Attachment #8772498 - Flags: review?(jmathies) → review+
I'll file a followup.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2eaabe71dd10 Adds a logging facility for intercepted COM traffic; r=jimm
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
NS_APP_CONTENT_PROCESS_TEMP_DIR should only be used if MOZ_CONTENT_SANDBOX is set, cfhttps://dxr.mozilla.org/comm-central/source/mozilla/xpcom/io/nsAppDirectoryServiceDefs.h#87. Currently this is not the case in https://hg.mozilla.org/mozilla-central/rev/2eaabe71dd10#l1.100 (noticed as it is causing failures on c-c).
Created attachment 8776077 [details] [diff] [review] Build fix for when MOZ_CONTENT_SANDBOX is not defined Whoops. Considering that I initially wrote NS_APP_CONTENT_PROCESS_TEMP_DIR, I should have known better!
Attachment #8776077 - Flags: review?(haftandilian)
Attachment #8776077 - Flags: review?(haftandilian) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a248e721aa179549a8b5a7b78c0ac8fed4603be Bug 1287875: Don't try to obtain NS_APP_CONTENT_PROCESS_TEMP_DIR unless MOZ_CONTENT_SANDBOX is defined; r=haik
Thanks for the quick fix. We (TB) can now compile again ;-)
You need to log in before you can comment on or make changes to this bug.