1287890 - CI: Create-test-environment shouldn't build docker images if just running non-docker tests

Status: RESOLVED FIXED

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[Robert Wood [:rwood]]

2:26 PM <gps> speaking of the non-docker suite, create-test-environment still builds docker images for it, wasting several minutes
2:26 PM <gps> we should add an env variable to create-test-environment to disable docker image generation or something

Comment 1

[Gregory Szorc [:gps]]

Attachment: testing: add NO_DOCKER environment variable to skip image building (bug 1287890);

If NO_DOCKER is set, we won't attempt to build Docker images.

This variable can be set in the Jenkins test environment to make the
"no Docker" test environment start faster.

Review commit: https://reviewboard.mozilla.org/r/65396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65396/

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8772653 [details]
testing: add NO_DOCKER environment variable to skip image building (bug 1287890);

https://reviewboard.mozilla.org/r/65396/#review62524

Awesome thanks, tried it out locally and ran the non-docker tests.

::: create-test-environment:236
(Diff revision 1)
> -  echo "You will not be able to run tests that require Docker.";
> +    echo "You will not be able to run tests that require Docker.";
> -  echo "Please see https://docs.docker.com/installation/ for how to install Docker.";
> +    echo "Please see https://docs.docker.com/installation/ for how to install Docker.";
> -  echo "When Docker is installed, re-run this script";
> +    echo "When Docker is installed, re-run this script";
> -  exit 1
> +    exit 1
> -}
> +  }
> +fi

Perhaps you may want to add an else and echo that the Docker images aren't being built because NO_DOCKER is set.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8772653 [details]
testing: add NO_DOCKER environment variable to skip image building (bug 1287890);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65396/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/044597f4a6a5
testing: add NO_DOCKER environment variable to skip image building ; r=rwood