Closed Bug 1287899 Opened 9 years ago Closed 6 years ago

Fetching Github pull request diffs in Splinter and details page should be configurable by product

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: dkl, Assigned: dkl)

Details

Automatically fetching the Github PR diffs and allowing commenting in Splinter may disrupt review workflows for certain projects which rely on commenting inside Github instead. So we should make it configurable per product and allow other projects to opt-in if they would like the feature enabled. - Add a checkbox to the product admin UI to enable/disable github pull request fetching - Update the template and code to not fetch the pull request diff if disabled and instead show a link to the pull request similar to what is done for MozReview links. dkl

MozReview is gone, and the GitHub PR support will be removed in Bug 1286448.

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Component: Extensions: BMO → Extensions
You need to log in before you can comment on or make changes to this bug.