If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Buttons in sliding panel overlay are not clickable

VERIFIED FIXED in Firefox 50

Status

()

Firefox
Downloads Panel
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: francois, Assigned: adw)

Tracking

({regression})

Trunk
Firefox 50
x86_64
Linux
regression
Points:
---

Firefox Tracking Flags

(firefox47 unaffected, firefox48 unaffected, firefox49 unaffected, firefox50 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8772541 [details]
Screencast demonstrating the problem

The new sliding panel overlay from the downloads panel has buttons to open or remove downloaded files that have been flagged as malware.

Unfortunately, the buttons don't seem to work on Nightly.

Steps:

1. Go to https://testsafebrowsing.appspot.com/
2. Download #5 under Desktop Download Warnings ("Should show an "uncommon" warning, for .exe: link [W]")
3. Click on download panel icon
4. Click on the arrow to trigger the overlay
5. Click on "Open"
6. Click on "Remove file"
7. Open the download panel again by clicking on the icon.

Expected:

- Step 5: Clicking "Open" should trigger the confirmation dialog with the warning.
- Step 6: The file should be made inaccessible.
- Step 7: The overlay should not be accessible through the arrow.

Actual:

- Step 5: The "Open" button doesn't react to clicks.
- Step 6, The "Remove file" button closes the download panel but doesn't perform the action.
- Step 7: The arrow is still there and we can still get to the overlay despite having "removed the file".
I used mozregression to find out when this has regressed and reached the following pushlog: 
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=52679ce4756c53fd88054a55da482291c26ef8db&tochange=9694e371363590c8dace6629dc4d57f1af7206f2

From that, Bug 1252509 stands out. As far as I can tell, the buttons that came with the new UI never did work.
status-firefox47: --- → unaffected
status-firefox48: --- → unaffected
status-firefox49: --- → unaffected
Flags: needinfo?(adw)
(Assignee)

Comment 2

a year ago
I can't actually reproduce this bug, and we have an automated test for this.  I wonder if this is Linux-only.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Flags: needinfo?(adw)
(Assignee)

Comment 3

a year ago
François, Ciprian, could you please try these builds?  Maybe this is related to bug 1280709.

https://archive.mozilla.org/pub/firefox/try-builds/dwillcoxon@mozilla.com-be73e25b441dc1cfff2d7cefdf14c13b618f76c2/
Flags: needinfo?(francois)
(Assignee)

Comment 4

a year ago
Oh, I can reproduce on Windows.  The problem is that DownloadsViewController.supportsCommand returns false because `element` is null I guess because the wrong thing is focused.
Flags: needinfo?(francois)
(Assignee)

Comment 5

a year ago
Created attachment 8774599 [details]
Bug 1287914 - Buttons in sliding panel overlay are not clickable.

Review commit: https://reviewboard.mozilla.org/r/67058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67058/
Attachment #8774599 - Flags: review?(jaws)
(Assignee)

Comment 6

a year ago
This modifies the controller implementation to check if the blocked subview is showing.  If it is, then it checks if the command is one that the blocked subview supports.

This also makes sure an element in the main view is focused when hiding the subview, since the controller's logic depends on the focused element.
Comment on attachment 8774599 [details]
Bug 1287914 - Buttons in sliding panel overlay are not clickable.

https://reviewboard.mozilla.org/r/67058/#review64168

Does the automated test referenced in https://bugzilla.mozilla.org/show_bug.cgi?id=1287914#c2 need to get updated so it will catch this?
Attachment #8774599 - Flags: review?(jaws) → review+
(Assignee)

Comment 8

a year ago
Comment on attachment 8774599 [details]
Bug 1287914 - Buttons in sliding panel overlay are not clickable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67058/diff/1-2/
(Assignee)

Comment 9

a year ago
Good point, the test was calling click() on the buttons, which is why it didn't catch this.  Changed to synthesizeMouse().
Thanks

Comment 11

a year ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e79dedcd251
Buttons in sliding panel overlay are not clickable. r=jaws
sorry had to back this out because this caused frequent failures like https://treeherder.mozilla.org/logviewer.html#?job_id=1016850&repo=autoland
Flags: needinfo?(adw)

Comment 13

a year ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07c2278d03ee
Backed out changeset 6e79dedcd251 for failing on own test
(Assignee)

Comment 14

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cafffe0a338
(Assignee)

Comment 15

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=04540c824653
(Assignee)

Comment 16

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f02669ca2cc
Flags: needinfo?(adw)
(Assignee)

Comment 17

a year ago
https://hg.mozilla.org/integration/fx-team/rev/d04e5bdd5b67f87fba285bf48253b279cbc58ac1
Bug 1287914 - Buttons in sliding panel overlay are not clickable. r=jaws

Comment 18

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d04e5bdd5b67
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
reproduced this bug in firefox nightly 50.0a1 (2016-07-19) with windows 10 (64 bit)

Verified this bug as fixed with latest firefox nightly 50.0a1 (Build ID: 20160801030227)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
QA Whiteboard: [bugday-20160803]
I was able to reproduce this issue on Nightly 50.0a1 from 2016-07-19 using Ubuntu 16.04 LTS, 64-bit. 

This is verified fixed using latest Nightly build 50.0a1, (2016-08-01) running Ubuntu 16.04 LTS, 64-bit.
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
You need to log in before you can comment on or make changes to this bug.