1287917 - Ensure ScrollMetadata::sNullMetadata is initialized in the GPU process

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

GPU process doesn't create gfxPlatform since it entrains so many other things, so we need to factor out ScrollMetadata initialization somehow.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

In bug 1219296 where this was added there was a bunch of discussion about where to put it. One of the things we concluded was that it's used even in APZ-disabled scenarios and so probably doesn't belong in the APZ code. Also it's used in gtests, so we couldn't put it in CompositorBridgeParent. Can we instead just put those two lines into a static function in gfxPlatform? It would be exactly the same set up as you have in this patch, but gfxPlatform::InitNullMetadata instead of APZCTreeManager::Init(). You won't need to call gfxPlatform::Init() in the GPU process.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch v2

Makes sense

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8772619 [details] [diff] [review]
patch v2

Review of attachment 8772619 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7f6c64fe03
Ensure GPU process initializes ScrollMetadata::sNullMetrics. (bug 1287917, r=kats)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b7f6c64fe03