Closed Bug 1287917 Opened 3 years ago Closed 3 years ago

Ensure ScrollMetadata::sNullMetadata is initialized in the GPU process

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
GPU process doesn't create gfxPlatform since it entrains so many other things, so we need to factor out ScrollMetadata initialization somehow.
Attachment #8772552 - Flags: review?(bugmail)
In bug 1219296 where this was added there was a bunch of discussion about where to put it. One of the things we concluded was that it's used even in APZ-disabled scenarios and so probably doesn't belong in the APZ code. Also it's used in gtests, so we couldn't put it in CompositorBridgeParent. Can we instead just put those two lines into a static function in gfxPlatform? It would be exactly the same set up as you have in this patch, but gfxPlatform::InitNullMetadata instead of APZCTreeManager::Init(). You won't need to call gfxPlatform::Init() in the GPU process.
Attached patch patch v2Splinter Review
Makes sense
Attachment #8772552 - Attachment is obsolete: true
Attachment #8772552 - Flags: review?(bugmail)
Attachment #8772619 - Flags: review?(bugmail)
Comment on attachment 8772619 [details] [diff] [review]
patch v2

Review of attachment 8772619 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8772619 - Flags: review?(bugmail) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7f6c64fe03
Ensure GPU process initializes ScrollMetadata::sNullMetrics. (bug 1287917, r=kats)
https://hg.mozilla.org/mozilla-central/rev/9b7f6c64fe03
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.