Move Java bindings to mozilla::java namespace

RESOLVED FIXED in Firefox 50

Status

()

Core
Widget: Android
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
mozilla50
All
Android
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
Moving the auto-generated bindings to mozilla::java avoids conflicts, and makes it more clear that we're using Java bindings in code.
(Assignee)

Comment 1

2 years ago
Created attachment 8772599 [details] [diff] [review]
Move Java bindings to mozilla::java namespace (v1)

Currently, auto-generated Java bindings are in the mozilla::widget
namespace, and that potentially conflicts with code under
widget/android. Moving the bindings to mozilla::java avoids conflicts
and makes it more clear that we're using Java bindings.
Attachment #8772599 - Flags: review?(snorp)
(Assignee)

Comment 2

2 years ago
Created attachment 8772600 [details] [diff] [review]
Update existing code to use mozilla::java (v1)
Attachment #8772600 - Flags: review+
(Assignee)

Comment 3

2 years ago
Created attachment 8772601 [details] [diff] [review]
Improve usage of StringParam in PrefsHelper (v1)

PrefsHelper uses Maybe<> as a replacement for a ternary expression, in
order to work around jni::StringParam's lack of copy constructor.
However, we can add a move constructor to StringParam, which lets us use
it in a ternary expression, and avoid the awkwardness of Maybe<>.
Attachment #8772601 - Flags: review+
Attachment #8772599 - Flags: review?(snorp) → review+

Comment 4

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cf61343793a
Move Java bindings to mozilla::java namespace; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/684888aeee81
Update existing code to use mozilla::java; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/e954e5a93482
Improve usage of StringParam in PrefsHelper; r=me
backed this out for android bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=32314092&repo=mozilla-inbound
Flags: needinfo?(nchen)

Comment 7

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/438384ed5ecf
Move Java bindings to mozilla::java namespace; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4baceb961e6
Update existing code to use mozilla::java; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/44454776e07f
Improve usage of StringParam in PrefsHelper; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/4842ac3d86e9
Clobber; r=me
(Assignee)

Comment 8

2 years ago
Repushed with clobber.
Flags: needinfo?(nchen)

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/438384ed5ecf
https://hg.mozilla.org/mozilla-central/rev/a4baceb961e6
https://hg.mozilla.org/mozilla-central/rev/44454776e07f
https://hg.mozilla.org/mozilla-central/rev/4842ac3d86e9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.