1287946 - Move Java bindings to mozilla::java namespace

Status: RESOLVED FIXED

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Moving the auto-generated bindings to mozilla::java avoids conflicts, and makes it more clear that we're using Java bindings in code.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Created attachment 8772599 [details] [diff] [review]
Move Java bindings to mozilla::java namespace (v1)

Currently, auto-generated Java bindings are in the mozilla::widget
namespace, and that potentially conflicts with code under
widget/android. Moving the bindings to mozilla::java avoids conflicts
and makes it more clear that we're using Java bindings.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Created attachment 8772600 [details] [diff] [review]
Update existing code to use mozilla::java (v1)

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Created attachment 8772601 [details] [diff] [review]
Improve usage of StringParam in PrefsHelper (v1)

PrefsHelper uses Maybe<> as a replacement for a ternary expression, in
order to work around jni::StringParam's lack of copy constructor.
However, we can add a move constructor to StringParam, which lets us use
it in a ternary expression, and avoid the awkwardness of Maybe<>.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cf61343793a
Move Java bindings to mozilla::java namespace; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/684888aeee81
Update existing code to use mozilla::java; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/e954e5a93482
Improve usage of StringParam in PrefsHelper; r=me

Comment 5

[Carsten Book [:Tomcat]]

backed this out for android bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=32314092&repo=mozilla-inbound

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a44f609b1f
Backed out changeset e954e5a93482 
https://hg.mozilla.org/integration/mozilla-inbound/rev/5643545ad499
Backed out changeset 684888aeee81 
https://hg.mozilla.org/integration/mozilla-inbound/rev/de1db0ba27a7
Backed out changeset 0cf61343793a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/438384ed5ecf
Move Java bindings to mozilla::java namespace; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4baceb961e6
Update existing code to use mozilla::java; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/44454776e07f
Improve usage of StringParam in PrefsHelper; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/4842ac3d86e9
Clobber; r=me

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Repushed with clobber.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/438384ed5ecf
https://hg.mozilla.org/mozilla-central/rev/a4baceb961e6
https://hg.mozilla.org/mozilla-central/rev/44454776e07f
https://hg.mozilla.org/mozilla-central/rev/4842ac3d86e9