Closed
Bug 1287946
Opened 6 years ago
Closed 6 years ago
Move Java bindings to mozilla::java namespace
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
Details
Attachments
(3 files)
3.63 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
104.56 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
5.20 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
Moving the auto-generated bindings to mozilla::java avoids conflicts, and makes it more clear that we're using Java bindings in code.
Assignee | ||
Comment 1•6 years ago
|
||
Currently, auto-generated Java bindings are in the mozilla::widget namespace, and that potentially conflicts with code under widget/android. Moving the bindings to mozilla::java avoids conflicts and makes it more clear that we're using Java bindings.
Attachment #8772599 -
Flags: review?(snorp)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8772600 -
Flags: review+
Assignee | ||
Comment 3•6 years ago
|
||
PrefsHelper uses Maybe<> as a replacement for a ternary expression, in order to work around jni::StringParam's lack of copy constructor. However, we can add a move constructor to StringParam, which lets us use it in a ternary expression, and avoid the awkwardness of Maybe<>.
Attachment #8772601 -
Flags: review+
Attachment #8772599 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0cf61343793a Move Java bindings to mozilla::java namespace; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/684888aeee81 Update existing code to use mozilla::java; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/e954e5a93482 Improve usage of StringParam in PrefsHelper; r=me
Comment 5•6 years ago
|
||
backed this out for android bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=32314092&repo=mozilla-inbound
Flags: needinfo?(nchen)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a44f609b1f Backed out changeset e954e5a93482 https://hg.mozilla.org/integration/mozilla-inbound/rev/5643545ad499 Backed out changeset 684888aeee81 https://hg.mozilla.org/integration/mozilla-inbound/rev/de1db0ba27a7 Backed out changeset 0cf61343793a
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/438384ed5ecf Move Java bindings to mozilla::java namespace; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/a4baceb961e6 Update existing code to use mozilla::java; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/44454776e07f Improve usage of StringParam in PrefsHelper; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/4842ac3d86e9 Clobber; r=me
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/438384ed5ecf https://hg.mozilla.org/mozilla-central/rev/a4baceb961e6 https://hg.mozilla.org/mozilla-central/rev/44454776e07f https://hg.mozilla.org/mozilla-central/rev/4842ac3d86e9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•8 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•