Closed Bug 1287948 Opened 8 years ago Closed 8 years ago

Use BufferMode::None for snapshots

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jrmuizel, Unassigned)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Switch snapshotting to BufferMode::BUFFER_NONE
2.84 KB, patch
nical
: review+
Details | Diff | Splinter Review 
We shouldn't need the extra buffer in this case.
Whiteboard: [gfx-noted]
To make this work we need to memset the buffer that we use for snapshot drawing so that we can draw on it directly. I could've avoided the memset for opaque content formats but it didn't seem worth as the only place we use this seems to be with content=COLOR_ALPHA
Attachment #8773058 - Flags: review?(nical.bugzilla)
Attachment #8773058 - Flags: review?(nical.bugzilla) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf14af43c5a
Use BufferMode::None for snapshots. r=nical
https://hg.mozilla.org/mozilla-central/rev/fcf14af43c5a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: