Closed Bug 1288053 Opened 5 years ago Closed 5 years ago

Add New Jobs fails due to new TaskGraph changes

Categories

(Tree Management :: Treeherder: API, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martianwars, Assigned: martianwars)

References

Details

Attachments

(1 file)

This has been done due to the merge of https://bugzilla.mozilla.org/show_bug.cgi?id=1281004, which has changed the format of the full-task-graph
Comment on attachment 8772784 [details] [review]
[treeherder] martiansideofthemoon:fast > mozilla:master

I hope this is okay :)
Attachment #8772784 - Flags: review?(emorley)
Assignee: nobody → kalpeshk2011
Blocks: 1254325
Status: NEW → ASSIGNED
Component: Treeherder → Treeherder: API
Depends on: 1281004
Priority: -- → P2
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=e767809a645b is the push where I was getting the errors. On checking I found out that it was because of a missing treeherder-->build key in the taskgraph. Is this a problem on TC side @dustin?
Flags: needinfo?(dustin)
Comment on attachment 8772784 [details] [review]
[treeherder] martiansideofthemoon:fast > mozilla:master

Left a comment :-)
Attachment #8772784 - Flags: review?(emorley) → review-
Attachment #8772784 - Flags: review- → review?(emorley)
Comment on attachment 8772784 [details] [review]
[treeherder] martiansideofthemoon:fast > mozilla:master

It sounds like we're not sure yet if the missing `build` key is intentional or not (comment 3).

Until we know that, we should hold off here.
Attachment #8772784 - Flags: review?(emorley)
Ah, so based on conversations with greg and
  https://github.com/taskcluster/taskcluster-treeherder/blob/master/schemas/task-treeherder-config.yml
I put the relevant information in task.extra.treeherder.machine.platform only.  I don't (well, didn't) think build.platform is used at all.

Platforms are still a big old mess, so there's going to be a refactor coming (bug 1286086).

For the moment, I'd say just use machine.platform instead of build.platform.
Flags: needinfo?(dustin)
Attachment #8772784 - Flags: review?(emorley)
Comment on attachment 8772784 [details] [review]
[treeherder] martiansideofthemoon:fast > mozilla:master

I've left some more comments
Attachment #8772784 - Flags: review?(emorley) → review-
Attachment #8772784 - Flags: review- → review?(emorley)
Attachment #8772784 - Flags: review?(emorley) → review+
Deployed to production :-)

(The pulse_actions part can happen in another bug)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1288220
You need to log in before you can comment on or make changes to this bug.