1288124 - Replace home panels with single activity stream panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: as-panel-mock.png

Only if build/feature flag (bug ) is set: Replace home panel UI with single activity stream panel. We can start with an empty panel. There are sub bugs for the specific functionality.

Comment 1

[Andrzej Hunt :ahunt]

I'll start with this (I've played with the homepanels and homepanel config in the recent past, so I'm not too unfamiliar with this code)!

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1288124 - Add basic/blank Activity Stream panel and show if flag is enabled

Review commit: https://reviewboard.mozilla.org/r/66090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66090/

Comment 3

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8773397 [details]
Bug 1288124 - Add basic/blank Activity Stream panel and show if flag is enabled

https://reviewboard.mozilla.org/r/66090/#review63066

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://reviewboard.mozilla.org/r/66090/#review63590

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:1
(Diff revision 1)
> +package org.mozilla.gecko.home.activitystream;

nit: license

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:16
(Diff revision 1)
> +import org.mozilla.gecko.home.HomeBanner;
> +import org.mozilla.gecko.home.HomeFragment;
> +import org.mozilla.gecko.home.HomeScreen;
> +
> +/**
> + * Created by andrzejhunt on 7/21/16.

nope :)

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:18
(Diff revision 1)
> +import org.mozilla.gecko.home.HomeScreen;
> +
> +/**
> + * Created by andrzejhunt on 7/21/16.
> + */
> +public class ActivityStream extends LinearLayout implements HomeScreen {

For now we could make this a FrameLayout.

::: mobile/android/base/resources/layout/gecko_app.xml:64
(Diff revision 1)
>                  <ViewStub android:id="@+id/home_pager_stub"
>                            android:layout="@layout/home_pager"
>                            android:layout_width="match_parent"
>                            android:layout_height="match_parent"/>
>  
> +                <ViewStub android:id="@+id/activity_stream_stub"
> +                          android:layout="@layout/activity_stream"
> +                          android:layout_width="match_parent"
> +                          android:layout_height="match_parent"/>

I wonder if eventually we want to have just one ViewStub and then decide in code which layout to inflate here:
https://developer.android.com/reference/android/view/ViewStub.html#setLayoutResource(int)

Comment 5

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/34d992753650814d9dc84b152e0b72c1e64d178f
Bug 1288124 - Add basic/blank Activity Stream panel and show if flag is enabled r=jonalmeida,sebastian

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34d992753650