Closed Bug 1288124 Opened 3 years ago Closed 3 years ago

Replace home panels with single activity stream panel

Categories

(Firefox for Android :: Awesomescreen, defect, P1)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 50
Iteration:
1.1
Tracking Status
firefox50 --- fixed

People

(Reporter: sebastian, Assigned: ahunt)

References

Details

(Whiteboard: [MobileAS])

Attachments

(2 files)

Attached image as-panel-mock.png
Only if build/feature flag (bug ) is set: Replace home panel UI with single activity stream panel. We can start with an empty panel. There are sub bugs for the specific functionality.
I'll start with this (I've played with the homepanels and homepanel config in the recent past, so I'm not too unfamiliar with this code)!
Assignee: nobody → ahunt
Depends on: 1288256
Component: General → Awesomescreen
Comment on attachment 8773397 [details]
Bug 1288124 - Add basic/blank Activity Stream panel and show if flag is enabled

https://reviewboard.mozilla.org/r/66090/#review63066
Attachment #8773397 - Flags: review?(jonalmeida942) → review+
https://reviewboard.mozilla.org/r/66090/#review63590

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:1
(Diff revision 1)
> +package org.mozilla.gecko.home.activitystream;

nit: license

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:16
(Diff revision 1)
> +import org.mozilla.gecko.home.HomeBanner;
> +import org.mozilla.gecko.home.HomeFragment;
> +import org.mozilla.gecko.home.HomeScreen;
> +
> +/**
> + * Created by andrzejhunt on 7/21/16.

nope :)

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:18
(Diff revision 1)
> +import org.mozilla.gecko.home.HomeScreen;
> +
> +/**
> + * Created by andrzejhunt on 7/21/16.
> + */
> +public class ActivityStream extends LinearLayout implements HomeScreen {

For now we could make this a FrameLayout.

::: mobile/android/base/resources/layout/gecko_app.xml:64
(Diff revision 1)
>                  <ViewStub android:id="@+id/home_pager_stub"
>                            android:layout="@layout/home_pager"
>                            android:layout_width="match_parent"
>                            android:layout_height="match_parent"/>
>  
> +                <ViewStub android:id="@+id/activity_stream_stub"
> +                          android:layout="@layout/activity_stream"
> +                          android:layout_width="match_parent"
> +                          android:layout_height="match_parent"/>

I wonder if eventually we want to have just one ViewStub and then decide in code which layout to inflate here:
https://developer.android.com/reference/android/view/ViewStub.html#setLayoutResource(int)
https://hg.mozilla.org/integration/fx-team/rev/34d992753650814d9dc84b152e0b72c1e64d178f
Bug 1288124 - Add basic/blank Activity Stream panel and show if flag is enabled r=jonalmeida,sebastian
https://hg.mozilla.org/mozilla-central/rev/34d992753650
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Whiteboard: [MobileAS s1.1]
Priority: -- → P1
Whiteboard: [MobileAS s1.1] → [MobileAS]
Iteration: --- → 1.1
You need to log in before you can comment on or make changes to this bug.