Expanding/collapsing file diffs is slow

NEW
Unassigned

Status

MozReview
Review Board: User Interface
2 years ago
2 years ago

People

(Reporter: Gijs, Unassigned)

Tracking

(Blocks: 1 bug)

Details

(Reporter)

Description

2 years ago
STR:

1. load https://reviewboard.mozilla.org/r/65552/diff/1#index_header

2. click any of the [+] buttons to expand the diff either to the top or to the bottom (to get 20 lines more context)

2b. click it again

ER:
Something faster than taking over 2 full seconds (I checked in the network timing in the console, so that's just the time of the request, never mind actually rendering the chunk)

Further expansion should be even faster because at this point it should have optimistically loaded the rest of the file (if it didn't do that to begin with)

AR:
Slow

3. collapse the bits you just expanded

ER:
instant collapsing, all it needs to do is remove the added context - no need for network lookups.

AR:
Another "Loading..." marker with spinner - feels just as slow as expanding the content.
(Reporter)

Comment 1

2 years ago
(In reply to :Gijs Kruitbosch from comment #0)
> 3. collapse the bits you just expanded
> 
> ER:
> instant collapsing, all it needs to do is remove the added context - no need
> for network lookups.
> 
> AR:
> Another "Loading..." marker with spinner - feels just as slow as expanding
> the content.

Looks like it actually *does* talk to the network. Why? :-\
(Reporter)

Updated

2 years ago
Blocks: 1288133
You need to log in before you can comment on or make changes to this bug.