Closed Bug 1288135 Opened 8 years ago Closed 8 years ago

tp5n.zip contains filenames with invalid characters

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: jmaher)

References

Details

As noticed when working on bug 1258539 the following zip file at least contains invalid characters (\ / : * ? " < > |) which cause a rename of the affected files on Windows. As result the web pages talos is testing do not contain all the elements as they should.

Here the archive which is causing problems:
http://people.mozilla.org/~jmaher/taloszips/zips/tp5n.zip

Affected files with ? and : in it are:

tp5n/uol.com.br/www.uol.com.br/b/ss/uoluolprod,uoltotal/1/H.22.1/?AQB=1&ndh=1&AQE=1

tp5n/linkedin.com/www.linkedin.com/in/christopherblizzard@goback=.nppvan_%2Flemuelf.html:

All the other files seem to be ok.

Joel, maybe we can fix those files and references for now and update the script which downloads those pages to check for invalid characters?
Flags: needinfo?(jmaher)
I assume that those files are not in a repository somewhere, so we seem to have to wait for Joel. He should be back by early next week.
Oh, and once done the updated archive also needs to be uploaded to:
http://talos-bundles.pvt.build.mozilla.org/zips/tp5n.zip
Callek, can you upload:
http://people.mozilla.org/~jmaher/taloszips/zips/tp5n.zip

to:
http://talos-bundles.pvt.build.mozilla.org/zips/tp5n.zip

I have verified on try that this .zip works just fine- I am not sure how to verify that it works with :whimboo's unzip logic.
Flags: needinfo?(jmaher) → needinfo?(bugspam.Callek)
Joel you could copy and paste the unpack() method from the patch of the other bug, and call it for your updated zip file on Windows.
:whimboo, that will take time, I can probably do it tomorrow if there are no other things which happen.  I don't have windows locally, so this means building up a try push, etc.
I have verified that the tp5n.zip file works well with the new unzip code:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=01903d8ff7813df1c9774c55062969d9534d3f28

Callek, please upload and we can move forward with :whimboo's unzip changes!
(In reply to Joel Maher ( :jmaher ) from comment #3)
> Callek, can you upload:
> http://people.mozilla.org/~jmaher/taloszips/zips/tp5n.zip
> 
> to:
> http://talos-bundles.pvt.build.mozilla.org/zips/tp5n.zip
> 
> I have verified on try that this .zip works just fine- I am not sure how to
> verify that it works with :whimboo's unzip logic.


[root@relengwebadm.private.scl3 ~]#  sha1sum /home/$ME/$ZIP
1acaa7f323bdf2e4eb18536e66cffcf084a889aa  /home/jwood/tp5n.zip
[root@relengwebadm.private.scl3 zips]# pwd
/mnt/netapp/relengweb/talos-bundles/zips
[root@relengwebadm.private.scl3 zips]# cp ./tp5n.zip ./tp5n.before_bug_1288135.zip
[root@relengwebadm.private.scl3 zips]# mv /home/$ME/$ZIP ./
mv: overwrite `./tp5n.zip'? y
[root@relengwebadm.private.scl3 zips]# ls -la ./tp5n.zip 
-rw-r--r-- 1 jwood jwood 81753172 Jul 29 06:26 ./tp5n.zip


And since I couldn't find docs, added to https://wiki.mozilla.org/ReleaseEngineering/Buildduty/Other_Duties#Tp5n.zip
Flags: needinfo?(bugspam.Callek)
I think it's all done on this bug now. Thank's a lot guys for the quick turnaround.
Assignee: nobody → jmaher
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.