Closed Bug 1288150 Opened 4 years ago Closed 4 years ago

[wasm] Debugger source view hang at removeBreakpoints when viewing AngryBots

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: yury, Assigned: yury)

References

()

Details

Attachments

(1 file)

STR:
0. Ensure javascript.options.wasm=true
1. Open new tab
2. Open devtools debugger (e.g. Alt+Cmd+S)
3. Navigate to https://webassembly.github.io/demo/AngryBots/
4. Click on the script ending with "> wasm"
5. Click on other script e.g. UnityProgress.js
6. Click on the script from step 4

Notice that devtools hang and then throw "slow script"-dialog.
Assignee: nobody → ydelendik
Comment on attachment 8772890 [details]
Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65590/diff/1-2/
Comment on attachment 8772890 [details]
Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65590/diff/2-3/
Attachment #8772890 - Flags: review?(jlong)
Comment on attachment 8772890 [details]
Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

https://reviewboard.mozilla.org/r/65590/#review63020

Holy crap, it iterates over every single line?? I can't wait to land the new debugger...

This looks like a great quick fix.
Attachment #8772890 - Flags: review?(jlong) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/e5341bb0157c
Add fast breakpoint presents check for removeBreakpoints. r=jlongster
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5341bb0157c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.