1288150 - [wasm] Debugger source view hang at removeBreakpoints when viewing AngryBots

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Yury Delendik (:yury)]

STR:
0. Ensure javascript.options.wasm=true
1. Open new tab
2. Open devtools debugger (e.g. Alt+Cmd+S)
3. Navigate to https://webassembly.github.io/demo/AngryBots/
4. Click on the script ending with "> wasm"
5. Click on other script e.g. UnityProgress.js
6. Click on the script from step 4

Notice that devtools hang and then throw "slow script"-dialog.

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

Review commit: https://reviewboard.mozilla.org/r/65590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65590/

Comment 2

[Yury Delendik (:yury)]

Comment on attachment 8772890 [details]
Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65590/diff/1-2/

Comment 3

[Yury Delendik (:yury)]

Comment on attachment 8772890 [details]
Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65590/diff/2-3/

Comment 4

[James Long (:jlongster)]

Comment on attachment 8772890 [details]
Bug 1288150 - Adds fast breakpoint presents check for removeBreakpoints.

https://reviewboard.mozilla.org/r/65590/#review63020

Holy crap, it iterates over every single line?? I can't wait to land the new debugger...

This looks like a great quick fix.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/e5341bb0157c
Add fast breakpoint presents check for removeBreakpoints. r=jlongster

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5341bb0157c